Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interpret: adjust error from constructing an invalid value #98520

Merged
merged 2 commits into from
Jun 30, 2022
Merged

interpret: adjust error from constructing an invalid value #98520

merged 2 commits into from
Jun 30, 2022

Conversation

RalfJung
Copy link
Member

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 26, 2022
@rust-highfive
Copy link
Collaborator

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

@rust-highfive
Copy link
Collaborator

r? @compiler-errors

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 26, 2022

📌 Commit 079cacf has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2022
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 26, 2022
@JohnTitor
Rollup merge of rust-lang#98520 - RalfJung:invalid, r=compiler-errors
542718e 
interpret: adjust error from constructing an invalid value
@JohnTitor JohnTitor mentioned this pull request Jun 26, 2022
Closed
@JohnTitor
Copy link
Member

Failed in rollup: #98557 (comment)
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 27, 2022
@RalfJung RalfJung force-pushed the invalid branch 2 times, most recently from bc029a3 to 8feb348 Compare June 27, 2022 03:21
@RalfJung
Copy link
Member Author

Ah, that test is only run for release builds so I cannot bless it... let's hope this is right.
@bors r=compiler-errors rollup=iffy

@bors
Copy link
Contributor

bors commented Jun 27, 2022

📌 Commit 8feb348abd2ee986eeff5ecfcb6d56afe6c53b8f has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 27, 2022
@RalfJung
Copy link
Member Author

@bors rollup=never

@bors
Copy link
Contributor

bors commented Jun 29, 2022

⌛ Testing commit 8feb348abd2ee986eeff5ecfcb6d56afe6c53b8f with merge 882c9a19dcc3b5c35b5076e833800b32f99e6f08...

@bors
Copy link
Contributor

bors commented Jun 29, 2022

💔 Test failed - checks-actions

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 29, 2022
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 29, 2022
@RalfJung
Copy link
Member Author

@bors retry dist-apple-various just stopped?

@rustbot
Copy link
Collaborator

rustbot commented Jun 29, 2022

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

Rebased to get up-to-date PR CI.
@bors r=compiler-errors

@RalfJung RalfJung closed this Jun 29, 2022
@RalfJung RalfJung reopened this Jun 29, 2022
@bors
Copy link
Contributor

bors commented Jun 29, 2022

📌 Commit 549940c has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jun 29, 2022

⌛ Testing commit 549940c with merge bf45371...

@bors
Copy link
Contributor

bors commented Jun 30, 2022

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing bf45371 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 30, 2022
@bors bors merged commit bf45371 into rust-lang:master Jun 30, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jun 30, 2022
@bors bors mentioned this pull request Jun 30, 2022
Merged
@RalfJung RalfJung deleted the invalid branch June 30, 2022 02:13
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bf45371): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 2.4% 2.4% 2
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -2.5% -2.9% 2
All 😿🎉 (primary) N/A N/A 0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@albertlarsan68 albertlarsan68 mentioned this pull request Dec 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
8 participants
@RalfJung @rust-highfive @rust-log-analyzer @compiler-errors @bors @JohnTitor @rustbot @rust-timer