Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use if let instead of manual match #94600

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Use if let instead of manual match #94600

merged 1 commit into from
Mar 4, 2022

Conversation

est31
Copy link
Member

@est31 est31 commented Mar 4, 2022

Factored out of #94139 . if let is better here than both let ... else and let ... = match.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Mar 4, 2022
@rust-highfive
Copy link
Collaborator

Some changes occurred in clean/types.rs.

cc @camelid

@rust-highfive
Copy link
Collaborator

r? @notriddle

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2022
@notriddle
Copy link
Contributor

@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented Mar 4, 2022

📌 Commit 18528a2 has been approved by notriddle

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 4, 2022
@Dylan-DPC
Rollup merge of rust-lang#94600 - est31:master, r=notriddle
01cba43 
Use if let instead of manual match

Factored out of rust-lang#94139 . `if let` is better here than both `let ... else` and `let ... = match`.
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 4, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 4, 2022
@matthiaskrgr
Rollup merge of rust-lang#94600 - est31:master, r=notriddle
aee7802 
Use if let instead of manual match

Factored out of rust-lang#94139 . `if let` is better here than both `let ... else` and `let ... = match`.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 4, 2022
@Dylan-DPC
Rollup merge of rust-lang#94600 - est31:master, r=notriddle
882f0f1 
Use if let instead of manual match

Factored out of rust-lang#94139 . `if let` is better here than both `let ... else` and `let ... = match`.
@bors bors merged commit b4baef5 into rust-lang:master Mar 4, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
5 participants
@est31 @rust-highfive @notriddle @bors @rustbot