Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add const generics test #90578

Merged
merged 2 commits into from
Nov 19, 2021
Merged

add const generics test #90578

merged 2 commits into from
Nov 19, 2021

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Nov 4, 2021

cc #89829 (comment)

r? rust-lang/project-const-generics

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 4, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lcnr lcnr added the A-const-generics Area: const generics (parameters and arguments) label Nov 5, 2021
@Mark-Simulacrum
Copy link
Member

r=me unless you actually want a const-generics group review (test seems OK to me but I'm not an expert)

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2021
@lcnr
Copy link
Contributor Author

lcnr commented Nov 8, 2021

@bors r=Mark-Simulacrum rollup

@bors
Copy link
Contributor

bors commented Nov 8, 2021

📌 Commit 084b232 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 8, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 8, 2021
@matthiaskrgr
Rollup merge of rust-lang#90578 - lcnr:add-test, r=Mark-Simulacrum
183d154 
add const generics test

cc rust-lang#89829 (comment)

r? rust-lang/project-const-generics
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 8, 2021
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 8, 2021
@matthiaskrgr
Rollup merge of rust-lang#90578 - lcnr:add-test, r=Mark-Simulacrum
d1d3261 
add const generics test

cc rust-lang#89829 (comment)

r? rust-lang/project-const-generics
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 8, 2021
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 8, 2021
@matthiaskrgr
Rollup merge of rust-lang#90578 - lcnr:add-test, r=Mark-Simulacrum
98db52d 
add const generics test

cc rust-lang#89829 (comment)

r? rust-lang/project-const-generics
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 8, 2021
Closed
@matthiaskrgr
Copy link
Member

looks like this failed in a rollup.?
#90710 (comment)
might also be that some of the other PRs changes this prs output.
@bors r-
feel free to re-r+ if I'm wrong 😅

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 8, 2021
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 11, 2021
@lcnr
Copy link
Contributor Author

lcnr commented Nov 17, 2021

@bors r=Mark-Simulacrum rollup

it seems like the output didn't change on master 🤔

@bors
Copy link
Contributor

bors commented Nov 17, 2021

📌 Commit 084b232 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 17, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 18, 2021
@matthiaskrgr
Rollup merge of rust-lang#90578 - lcnr:add-test, r=Mark-Simulacrum
63ee3b2 
add const generics test

cc rust-lang#89829 (comment)

r? rust-lang/project-const-generics
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 18, 2021
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 18, 2021
@JohnTitor
Rollup merge of rust-lang#90578 - lcnr:add-test, r=Mark-Simulacrum
b79d0e3 
add const generics test

cc rust-lang#89829 (comment)

r? rust-lang/project-const-generics
@JohnTitor JohnTitor mentioned this pull request Nov 18, 2021
Closed
@JohnTitor
Copy link
Member

Failed in rollup: #91013 (comment)
@bors r-

You should bless tests with compare-mode=nll.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 18, 2021
@lcnr
Copy link
Contributor Author

lcnr commented Nov 18, 2021

aaah, completely missed that :( thanks

@bors r=Mark-Simulacrum rollup

@bors
Copy link
Contributor

bors commented Nov 18, 2021

📌 Commit 8ace192 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 18, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 18, 2021
@matthiaskrgr
Rollup merge of rust-lang#90578 - lcnr:add-test, r=Mark-Simulacrum
439afef 
add const generics test

cc rust-lang#89829 (comment)

r? rust-lang/project-const-generics
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 18, 2021
Closed
@JohnTitor JohnTitor mentioned this pull request Nov 19, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 19, 2021
@bors
Auto merge of rust-lang#91033 - JohnTitor:rollup-sr9zg6o, r=JohnTitor
e8423e6 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#89258 (Make char conversion functions unstably const)
 - rust-lang#90578 (add const generics test)
 - rust-lang#90633 (Refactor single variant `Candidate` enum into a struct)
 - rust-lang#90800 (bootstap: create .cargo/config only if not present)
 - rust-lang#90942 (windows: Return the "Not Found" error when a path is empty)
 - rust-lang#90947 (Move some tests to more reasonable directories - 9.5)
 - rust-lang#90961 (Suggest removal of arguments for unit variant, not replacement)
 - rust-lang#90990 (Arenas cleanup)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 81fd016 into rust-lang:master Nov 19, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 19, 2021
@lcnr lcnr mentioned this pull request Dec 11, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-const-generics Area: const generics (parameters and arguments) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
9 participants
@lcnr @rust-highfive @rust-log-analyzer @Mark-Simulacrum @bors @matthiaskrgr @JohnTitor @apiraino @rustbot