Rollup of 12 pull requests #90137
Closed
Rollup of 12 pull requests #90137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The support for runtime multi-threading was removed from LLVM. Calls to `LLVMStartMultithreaded` became no-ops equivalent to checking if LLVM was compiled with support for threads http://reviews.llvm.org/D4216.
It's a visitor property rather than something that needs to be determined at runtime
The const qualification was so far performed before the promotion and the implementation assumed that it will never encounter a promoted. With `const_precise_live_drops` feature, checking for live drops is delayed until after drop elaboration, which in turn runs after promotion. so the assumption is no longer true. When evaluating `NeedsNonConstDrop` it is now possible to encounter promoteds. Use type base qualification for the promoted. It is a sound approximation in general, and in the specific case of promoteds and `NeedsNonConstDrop` it is precise.
Now explicitly says negative value.
rustbot doesn't allow unauthenticated users to set `I-nominated`; apply the same permissions to the new `I-*nominated` labels.
Previously, it wasn't clear whether "This could include" was referring to logic errors, or undefined behaviour. Tweak wording to clarify this sentence does not relate to UB.
…rk-Simulacrum Clarify undefined behaviour in binary heap, btree and hashset docs Previously, it wasn't clear whether "This could include" was referring to logic errors, or undefined behaviour. Tweak wording to clarify this sentence does not relate to UB.
Cleanup LLVM multi-threading checks The support for runtime multi-threading was removed from LLVM. Calls to `LLVMStartMultithreaded` became no-ops equivalent to checking if LLVM was compiled with support for threads http://reviews.llvm.org/D4216.
Update E0637 description to mention `&` w/o an explicit lifetime name Deal with rust-lang#89824 (comment). Another solution would be splitting the error code into two as (I think) it's a bit unclear to users why they have the same error code.
Change `Duration::[try_]from_secs_{f32, f64}` underflow error
The error message now says that it was a negative value.
Fixes rust-lang#89913.
rustc_ast: Turn `MutVisitor::token_visiting_enabled` into a constant It's a visitor property rather than something that needs to be determined at runtime
…=spastorino Reject closures in patterns Fixes rust-lang#90013.
…i-obk Fix const qualification when executed after promotion The const qualification was so far performed before the promotion and the implementation assumed that it will never encounter a promoted. With `const_precise_live_drops` feature, checking for live drops is delayed until after drop elaboration, which in turn runs after promotion. so the assumption is no longer true. When evaluating `NeedsNonConstDrop` it is now possible to encounter promoteds. Use type base qualification for the promoted. It is a sound approximation in general, and in the specific case of promoteds and `NeedsNonConstDrop` it is precise. Fixes rust-lang#89938.
…crum Add a regression test for issue-83479 Add a regression test for rust-lang#83479 (comment), but not close the issue, see rust-lang#83479 (comment).
Add some tests for const_generics_defaults I think this covers some of the stuff required for stabilisation report, some of these tests are probably covering stuff we already have but it can't hurt to have more :) r? ``@lcnr``
Add test for issue rust-lang#78561 Adds test for and closes rust-lang#78561 which previously crashed compiler.
…k-Simulacrum CI: make docker cache download attempt time out after 10 minutes Might help to prevent timeouts we have been seeing: * https://github.com/rust-lang-ci/rust/runs/3946294286?check_suite_focus=true#step:25:23 * https://github.com/rust-lang-ci/rust/runs/3956799200?check_suite_focus=true#step:25:22 * https://github.com/rust-lang-ci/rust/runs/3962928502?check_suite_focus=true#step:25:23
…=Mark-Simulacrum triagebot: Treat `I-*nominated` like `I-nominated` rustbot doesn't allow unauthenticated users to set `I-nominated`; apply the same permissions to the new `I-*nominated` labels.
|
@bors r+ p=12 rollup=never |
|
📌 Commit e394367 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit e394367 with merge 9b1c97951ad2c0e7b46bd0a05b59cb38066d9cd2... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit e394367 with merge 3c594100d143e1630ba07a7e7c34984092b86856... |
Merged
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
Uh, no luck? Re-created a bigger one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
&w/o an explicit lifetime name #89922 (Update E0637 description to mention&w/o an explicit lifetime name)Duration::[try_]from_secs_{f32, f64}underflow error #89944 (ChangeDuration::[try_]from_secs_{f32, f64}underflow error)MutVisitor::token_visiting_enabledinto a constant #89991 (rustc_ast: TurnMutVisitor::token_visiting_enabledinto a constant)region is not an ReVar: ReEarlyBound(0, 'a)with type_alias_impl_trait and particular type parameter bounds #78561)docker loadtime out after 10 minutes #90122 (CI: make docker cache download attempt time out after 10 minutes)I-*nominatedlikeI-nominated#90129 (triagebot: TreatI-*nominatedlikeI-nominated)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup