Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #89767

Merged
merged 16 commits into from
Oct 11, 2021
Merged

Rollup of 7 pull requests #89767

merged 16 commits into from
Oct 11, 2021

Commits on Oct 7, 2021

  1. bootstrap: don't use --merges to find commits

    Shallow clones can cause `git rev-list --merges` to miss merge
    commits. Omit it, because the most recent bors commit is
    almost always a merge commit.
    tlyu committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    6ff7204 View commit details
    Browse the repository at this point in the history
  2. bootstrap: add error messages re shallow history

    Exit with an error if we can't find a commit hash for downloading
    LLVM or rustc snapshots.
    tlyu committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    8e46742 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2021

  1. Configuration menu
    Copy the full SHA
    58cc18c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b5c12b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ecd7ea8 View commit details
    Browse the repository at this point in the history
  4. Fix RUSTC_LOG handling

    Rustc was incorrectly reading the value of `RUSTC_LOG` as the
    environment vairable with the logging configuration, rather than the
    logging configuration itself.
    matthewjasper committed Oct 10, 2021
    Configuration menu
    Copy the full SHA
    9e6e89a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cf2bcd1 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. ⬆️ rust-analyzer

    lnicola committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    687cc5d View commit details
    Browse the repository at this point in the history
  2. Cleanup .item-table CSS

    dns2utf8 committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    4bd7e96 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#89655 - tlyu:find-non-merge-commits, r=jyn514

    bootstrap: don't use `--merges` to look for commit hashes for downloading artifacts
    
    Shallow clones (and possibly worktrees, though I can't seem to reproduce the problem there) can cause `git rev-list --merges` to falsely return no results, even if a merge commit is present. Stop using the `--merges` option when looking for commit hashes that have build artifacts. `--first-parent` and `[email protected]` should be sufficient.
    
    Also exit with an error if the configuration asks for artifacts to be downloaded and we can't determine an appropriate commit hash to use to download artifacts.
    
    Fixes rust-lang#87890.
    
    r? ``@jyn514``
    ``@rustbot`` label +A-rustbuild +A-contributor-roadblock
    GuillaumeGomez authored Oct 11, 2021
    Configuration menu
    Copy the full SHA
    08a7a57 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#89726 - jkugelman:must-use-alloc-constructo…

    …rs, r=joshtriplett
    
    Add #[must_use] to alloc constructors
    
    Added `#[must_use]`. to the various forms of `new`, `pin`, and `with_capacity` in the `alloc` crate. No extra explanations given as I couldn't think of anything useful to add.
    
    I figure this deserves extra scrutiny compared to the other PRs I've done so far. In particular:
    
    * The 4 `pin`/`pin_in` methods I touched. Are there legitimate use cases for pinning and not using the result? Pinning's a difficult concept I'm not very comfortable with.
    * `Box`'s constructors. Do people ever create boxes just for the side effects... allocating or zeroing out memory?
    
    Parent issue: rust-lang#89692
    
    r? ``@joshtriplett``
    GuillaumeGomez authored Oct 11, 2021
    Configuration menu
    Copy the full SHA
    d7c9693 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#89729 - jkugelman:must-use-core-std-constru…

    …ctors, r=joshtriplett
    
    Add #[must_use] to core and std constructors
    
    Parent issue: rust-lang#89692
    
    r? ``@joshtriplett``
    GuillaumeGomez authored Oct 11, 2021
    Configuration menu
    Copy the full SHA
    77be7e4 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#89743 - matthewjasper:env-log-fix, r=jyn514

    Fix RUSTC_LOG handling
    
    Rustc was incorrectly reading the value of `RUSTC_LOG` as the environment vairable with the logging configuration, rather than the logging configuration itself.
    GuillaumeGomez authored Oct 11, 2021
    Configuration menu
    Copy the full SHA
    9183942 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#89753 - jkugelman:must-use-from_value-conve…

    …rsions, r=joshtriplett
    
    Add #[must_use] to from_value conversions
    
    I added two methods to the list myself. Clippy did not flag them because they take `mut` args, but neither modifies their argument.
    
    ```rust
    core::str           const unsafe fn from_utf8_unchecked_mut(v: &mut [u8]) -> &mut str;
    std::ffi::CString   unsafe fn from_raw(ptr: *mut c_char) -> CString;
    ```
    
    I put a custom note on `from_raw`:
    
    ```rust
    #[must_use = "call `drop(from_raw(ptr))` if you intend to drop the `CString`"]
    pub unsafe fn from_raw(ptr: *mut c_char) -> CString {
    ```
    
    Parent issue: rust-lang#89692
    
    r? ``@joshtriplett``
    GuillaumeGomez authored Oct 11, 2021
    Configuration menu
    Copy the full SHA
    96ffc74 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#89754 - dns2utf8:rustdoc_cleanup_css, r=Gui…

    …llaumeGomez
    
    Cleanup .item-table CSS
    
    The main table-like element must be `display: table;`
    
    r? `@GuillaumeGomez`
    GuillaumeGomez authored Oct 11, 2021
    Configuration menu
    Copy the full SHA
    f36c109 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#89761 - lnicola:rust-analyzer-2021-10-11, r…

    …=lnicola
    
    ⬆️ rust-analyzer
    
    r? ``@ghost``
    GuillaumeGomez authored Oct 11, 2021
    Configuration menu
    Copy the full SHA
    913b1de View commit details
    Browse the repository at this point in the history