-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #89767
Rollup of 7 pull requests #89767
Commits on Oct 7, 2021
-
bootstrap: don't use
--merges
to find commitsShallow clones can cause `git rev-list --merges` to miss merge commits. Omit it, because the most recent bors commit is almost always a merge commit.
Configuration menu - View commit details
-
Copy full SHA for 6ff7204 - Browse repository at this point
Copy the full SHA 6ff7204View commit details -
bootstrap: add error messages re shallow history
Exit with an error if we can't find a commit hash for downloading LLVM or rustc snapshots.
Configuration menu - View commit details
-
Copy full SHA for 8e46742 - Browse repository at this point
Copy the full SHA 8e46742View commit details
Commits on Oct 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 58cc18c - Browse repository at this point
Copy the full SHA 58cc18cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b5c12b - Browse repository at this point
Copy the full SHA 5b5c12bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ecd7ea8 - Browse repository at this point
Copy the full SHA ecd7ea8View commit details -
Rustc was incorrectly reading the value of `RUSTC_LOG` as the environment vairable with the logging configuration, rather than the logging configuration itself.
Configuration menu - View commit details
-
Copy full SHA for 9e6e89a - Browse repository at this point
Copy the full SHA 9e6e89aView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf2bcd1 - Browse repository at this point
Copy the full SHA cf2bcd1View commit details
Commits on Oct 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 687cc5d - Browse repository at this point
Copy the full SHA 687cc5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bd7e96 - Browse repository at this point
Copy the full SHA 4bd7e96View commit details -
Rollup merge of rust-lang#89655 - tlyu:find-non-merge-commits, r=jyn514
bootstrap: don't use `--merges` to look for commit hashes for downloading artifacts Shallow clones (and possibly worktrees, though I can't seem to reproduce the problem there) can cause `git rev-list --merges` to falsely return no results, even if a merge commit is present. Stop using the `--merges` option when looking for commit hashes that have build artifacts. `--first-parent` and `[email protected]` should be sufficient. Also exit with an error if the configuration asks for artifacts to be downloaded and we can't determine an appropriate commit hash to use to download artifacts. Fixes rust-lang#87890. r? ``@jyn514`` ``@rustbot`` label +A-rustbuild +A-contributor-roadblock
Configuration menu - View commit details
-
Copy full SHA for 08a7a57 - Browse repository at this point
Copy the full SHA 08a7a57View commit details -
Rollup merge of rust-lang#89726 - jkugelman:must-use-alloc-constructo…
…rs, r=joshtriplett Add #[must_use] to alloc constructors Added `#[must_use]`. to the various forms of `new`, `pin`, and `with_capacity` in the `alloc` crate. No extra explanations given as I couldn't think of anything useful to add. I figure this deserves extra scrutiny compared to the other PRs I've done so far. In particular: * The 4 `pin`/`pin_in` methods I touched. Are there legitimate use cases for pinning and not using the result? Pinning's a difficult concept I'm not very comfortable with. * `Box`'s constructors. Do people ever create boxes just for the side effects... allocating or zeroing out memory? Parent issue: rust-lang#89692 r? ``@joshtriplett``
Configuration menu - View commit details
-
Copy full SHA for d7c9693 - Browse repository at this point
Copy the full SHA d7c9693View commit details -
Rollup merge of rust-lang#89729 - jkugelman:must-use-core-std-constru…
…ctors, r=joshtriplett Add #[must_use] to core and std constructors Parent issue: rust-lang#89692 r? ``@joshtriplett``
Configuration menu - View commit details
-
Copy full SHA for 77be7e4 - Browse repository at this point
Copy the full SHA 77be7e4View commit details -
Rollup merge of rust-lang#89743 - matthewjasper:env-log-fix, r=jyn514
Fix RUSTC_LOG handling Rustc was incorrectly reading the value of `RUSTC_LOG` as the environment vairable with the logging configuration, rather than the logging configuration itself.
Configuration menu - View commit details
-
Copy full SHA for 9183942 - Browse repository at this point
Copy the full SHA 9183942View commit details -
Rollup merge of rust-lang#89753 - jkugelman:must-use-from_value-conve…
…rsions, r=joshtriplett Add #[must_use] to from_value conversions I added two methods to the list myself. Clippy did not flag them because they take `mut` args, but neither modifies their argument. ```rust core::str const unsafe fn from_utf8_unchecked_mut(v: &mut [u8]) -> &mut str; std::ffi::CString unsafe fn from_raw(ptr: *mut c_char) -> CString; ``` I put a custom note on `from_raw`: ```rust #[must_use = "call `drop(from_raw(ptr))` if you intend to drop the `CString`"] pub unsafe fn from_raw(ptr: *mut c_char) -> CString { ``` Parent issue: rust-lang#89692 r? ``@joshtriplett``
Configuration menu - View commit details
-
Copy full SHA for 96ffc74 - Browse repository at this point
Copy the full SHA 96ffc74View commit details -
Rollup merge of rust-lang#89754 - dns2utf8:rustdoc_cleanup_css, r=Gui…
…llaumeGomez Cleanup .item-table CSS The main table-like element must be `display: table;` r? `@GuillaumeGomez`
Configuration menu - View commit details
-
Copy full SHA for f36c109 - Browse repository at this point
Copy the full SHA f36c109View commit details -
Rollup merge of rust-lang#89761 - lnicola:rust-analyzer-2021-10-11, r…
…=lnicola ⬆️ rust-analyzer r? ``@ghost``
Configuration menu - View commit details
-
Copy full SHA for 913b1de - Browse repository at this point
Copy the full SHA 913b1deView commit details