Allow `~const` bounds on trait assoc functions #88418

fee1-dead · 2021-08-28T07:40:59Z

oli-obk · 2021-08-28T14:44:49Z

src/test/ui/rfc-2632-const-trait-impl/trait-where-clause.rs

+
+trait Foo {
+    fn a();
+    fn b() where Self: ~const Bar;


A few more tests I think we should have:

where Self: ~const Foo

a const and a nonconst impl for such a trait

a monomorphic use that actually runs it

oli-obk · 2021-08-28T16:12:21Z

src/test/ui/rfc-2632-const-trait-impl/trait-where-clause-run.rs

+    const ANS1: u8 = Const::foo();
+    let ans2 = NonConst::foo();
+
+    assert_eq!(ANS1 + ans2, 42);


oli-obk · 2021-08-28T16:12:38Z

@bors r+

bors · 2021-08-28T16:12:39Z

📌 Commit ee02c8e has been approved by oli-obk

bors · 2021-08-30T04:48:51Z

⌛ Testing commit ee02c8e with merge 98c17e16ab9f27c1948e0c8d9aa262bfa0800128...

rust-log-analyzer · 2021-08-30T05:22:57Z

The job i686-msvc-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- [rustdoc] rustdoc\macro-document-private-duplicate.rs stdout ----

error: htmldocck failed!
status: exit code: 1
command: "C:\\hostedtoolcache\\windows\\Python\\3.9.6\\x64\\python3.exe" "D:\\a\\rust\\rust\\src/etc/htmldocck.py" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\rustdoc\\macro-document-private-duplicate" "D:\\a\\rust\\rust\\src/test\\rustdoc\\macro-document-private-duplicate.rs"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
12: @has check failed
 `PATTERN` did not match
 // @has macro_document_private_duplicate/macro.a_macro.html 'Doc 1.'
19: @!has check failed
 `PATTERN` did not match
 // @!has macro_document_private_duplicate/macro.a_macro.html 'Doc 2.'
Encountered 2 errors

------------------------------------------




failures:
Some tests failed in compiletest suite=rustdoc mode=rustdoc host=i686-pc-windows-msvc target=i686-pc-windows-msvc
    [rustdoc] rustdoc\macro-document-private-duplicate.rs
test result: FAILED. 457 passed; 1 failed; 6 ignored; 0 measured; 0 filtered out; finished in 62.47s




command did not execute successfully: "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage0-tools-bin\\compiletest.exe" "--compile-lib-path" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2\\bin" "--run-lib-path" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2\\lib\\rustlib\\i686-pc-windows-msvc\\lib" "--rustc-path" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2\\bin\\rustc.exe" "--rustdoc-path" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2\\bin\\rustdoc.exe" "--src-base" "D:\\a\\rust\\rust\\src/test\\rustdoc" "--build-base" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\rustdoc" "--stage-id" "stage2-i686-pc-windows-msvc" "--suite" "rustdoc" "--mode" "rustdoc" "--target" "i686-pc-windows-msvc" "--host" "i686-pc-windows-msvc" "--llvm-filecheck" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\llvm\\build\\bin\\FileCheck.exe" "--nodejs" "C:\\Program Files\\nodejs\\node" "--npm" "C:\\Program Files\\nodejs\\npm" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0  -Lnative=D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\native\\rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0  -Lnative=D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\native\\rust-test-helpers" "--docck-python" "C:\\hostedtoolcache\\windows\\Python\\3.9.6\\x64\\python3.exe" "--lldb-python" "C:\\hostedtoolcache\\windows\\Python\\3.9.6\\x64\\python3.exe" "--gdb" "C:\\msys64\\usr\\bin\\gdb" "--llvm-version" "13.0.0-rust-1.56.0-nightly" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo cfguard codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver dwarflinker dwp engine executionengine extensions filecheck frontendopenacc frontendopenmp fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interfacestub interpreter ipo irreader jitlink libdriver lineeditor linker lto mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit orcshared orctargetprocess passes powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo webassemblyutils windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info xray" "--cc" "" "--cxx" "" "--cflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--channel" "nightly" "--color" "always"


Build completed unsuccessfully in 0:30:15
Build completed unsuccessfully in 0:30:15
make: *** [Makefile:72: ci-subset-1] Error 1

bors · 2021-08-30T05:23:49Z

💔 Test failed - checks-actions

oli-obk · 2021-08-30T09:17:50Z

@bors retry

Rollup of 10 pull requests Successful merges: - rust-lang#85017 (Add carrying_add, borrowing_sub, widening_mul, carrying_mul methods to integers) - rust-lang#86362 (Avoid cloning LocalDecls) - rust-lang#88391 (Fix json tuple struct enum variant ) - rust-lang#88399 (Disallow the aapcs CC on Aarch64) - rust-lang#88418 (Allow `~const` bounds on trait assoc functions) - rust-lang#88445 (Clean up the lowering of AST items) - rust-lang#88495 (Add `TcpStream::set_linger` and `TcpStream::linger`) - rust-lang#88501 (Use right span in prelude collision suggestions with macros. ) - rust-lang#88504 (Keep turbofish in prelude collision lint.) - rust-lang#88524 (Remove unnecessary `mut` from udp doctests) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

nalply · 2021-09-15T06:29:25Z

I got here by TWIR and I never have seen ~const in Rust. What's this? Sorry for the noise, ~const is not googlable.

oli-obk · 2021-09-15T06:45:35Z

it's placeholder syntax for "const if const" trait bounds: #67792

the full updated RFC text can be found at https://internals.rust-lang.org/t/pre-rfc-revamped-const-trait-impl-aka-rfc-2632/15192

rust-highfive assigned oli-obk Aug 28, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 28, 2021

Allow ~const bounds on trait assoc functions

523490e

fee1-dead force-pushed the trait-assoc-tilde-const branch from 3a18b5f to 523490e Compare August 28, 2021 08:03

oli-obk reviewed Aug 28, 2021

View reviewed changes

Add test cases

ee02c8e

oli-obk reviewed Aug 28, 2021

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 30, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2021

m-ou-se mentioned this pull request Aug 31, 2021

Rollup of 10 pull requests #88535

Merged

bors merged commit ab37e49 into rust-lang:master Aug 31, 2021

rustbot added this to the 1.56.0 milestone Aug 31, 2021

fee1-dead deleted the trait-assoc-tilde-const branch September 15, 2021 06:53

petrochenkov mentioned this pull request Sep 24, 2021

Test src\test\rustdoc\macro-document-private-duplicate.rs fails spuriously #89228

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow `~const` bounds on trait assoc functions #88418

Allow `~const` bounds on trait assoc functions #88418

fee1-dead commented Aug 28, 2021

oli-obk Aug 28, 2021

oli-obk Aug 28, 2021

oli-obk commented Aug 28, 2021

bors commented Aug 28, 2021

bors commented Aug 30, 2021

rust-log-analyzer commented Aug 30, 2021

bors commented Aug 30, 2021

oli-obk commented Aug 30, 2021

nalply commented Sep 15, 2021

oli-obk commented Sep 15, 2021

Allow ~const bounds on trait assoc functions #88418

Allow ~const bounds on trait assoc functions #88418

Conversation

fee1-dead commented Aug 28, 2021

oli-obk Aug 28, 2021

Choose a reason for hiding this comment

oli-obk Aug 28, 2021

Choose a reason for hiding this comment

oli-obk commented Aug 28, 2021

bors commented Aug 28, 2021

bors commented Aug 30, 2021

rust-log-analyzer commented Aug 30, 2021

bors commented Aug 30, 2021

oli-obk commented Aug 30, 2021

nalply commented Sep 15, 2021

oli-obk commented Sep 15, 2021

Allow `~const` bounds on trait assoc functions #88418

Allow `~const` bounds on trait assoc functions #88418