Stabilise raw_os_nonzero (NonZero_c_* integers) #88303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Jackson <[email protected]>
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jonas-schievink
added
relnotes
|
r? @m-ou-se for T-libs-api FCP |
|
FCP started at #82363 (comment) . |
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
JohnTitor
added
S-waiting-on-fcp
|
triage: The FCP seems to have been cancelled. |
So it has, thanks for spotting that. For some reason I wasn't subscribed to the FCP so I didn't notice. I agree with the FCP discussion that generics are much better. I have put this rework on my todo list (but as ever I may not get to it right away...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stabilises
raw_os_nonzero,NonZero_c_intetc. Tracking issue #82363, FCP needed.This was implemented in #82228 and merged in February.
There is one outstanding question, that of naming: should we be consistent with
c_int,c_long, etc., or withNonZeroU32etc. ? I chose the former and that's what's been in nightly since February. There are arguments for the latter. This is a bikeshed issue, but we do need to fix the colour of the paint before stabilisation.