Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implementors display #87035

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Fix implementors display #87035

merged 3 commits into from
Jul 13, 2021

Conversation

GuillaumeGomez
Copy link
Member

Part of #86632.

This PR does a few things:

  • It fixes of the JS rendered implementors.
  • It generates anchors for JS rendered implementors to make it coherent with the others.
  • It adds a test to ensure that we won't have the same issue again.
  • It changes the way we render the rustdoc-gui crates to simplify it a bit and also to allow to have dependencies without going through compiletest.

Before:

Screenshot from 2021-07-10 13-30-13

After:

Screenshot from 2021-07-10 21-11-15

I plan to add the [src] links in another PR because this one is already big enough.

cc @Mark-Simulacrum (for the bootstrap changes)

r? @Nemo157

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) A-rustdoc-js Area: Rustdoc's JS front-end labels Jul 10, 2021
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 10, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the fix-implementors-display branch from 3009536 to 3ec22f2 Compare July 10, 2021 19:29
@GuillaumeGomez
Copy link
Member Author

And I forgot to format as usual...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the fix-implementors-display branch from 3ec22f2 to 975e990 Compare July 11, 2021 10:02
This was referenced Jul 12, 2021
Closed
Closed
@GuillaumeGomez
Copy link
Member Author

cc @camelid

notriddle
notriddle reviewed Jul 12, 2021
View reviewed changes
@GuillaumeGomez GuillaumeGomez force-pushed the fix-implementors-display branch from 975e990 to bd81949 Compare July 12, 2021 17:04
@GuillaumeGomez
Copy link
Member Author

@bors: r=notriddle

@bors
Copy link
Contributor

bors commented Jul 12, 2021

📌 Commit bd81949 has been approved by notriddle

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2021
@JohnTitor JohnTitor mentioned this pull request Jul 12, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 13, 2021
@bors
Auto merge of rust-lang#87095 - JohnTitor:rollup-mn7ggy2, r=JohnTitor
14c0c3e 
Rollup of 11 pull requests

Successful merges:

 - rust-lang#86344 (Split MaybeUninit::write into new feature gate and stabilize it)
 - rust-lang#86811 (Remove unstable `io::Cursor::remaining`)
 - rust-lang#86846 (stdio_locked: add tracking issue)
 - rust-lang#86887 (rustdoc: remove dead code in `clean`)
 - rust-lang#87007 (Fix rust-analyzer install when not available.)
 - rust-lang#87035 (Fix implementors display)
 - rust-lang#87065 (Fix ICE with unsized type in const pattern)
 - rust-lang#87070 (Simplify future incompatible reporting.)
 - rust-lang#87077 (:arrow_up: rust-analyzer)
 - rust-lang#87078 (Rustdoc: suggest removing disambiguator if linking to field)
 - rust-lang#87089 (CTFE engine: small cleanups)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fab45bf into rust-lang:master Jul 13, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 13, 2021
@GuillaumeGomez GuillaumeGomez deleted the fix-implementors-display branch July 13, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notriddle notriddle notriddle approved these changes

Assignees

@Nemo157 Nemo157

Labels
A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-ui Area: Rustdoc UI (generated HTML) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
7 participants
@GuillaumeGomez @rust-highfive @rust-log-analyzer @bors @notriddle @Nemo157 @rustbot