-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "List trait impls before methods from deref in the sidebar ..." #86564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Rustdoc's output" This reverts commit 8a05892.
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 23, 2021
@bors r+ |
📌 Commit 093e246 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 23, 2021
jyn514
added
the
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
label
Jun 23, 2021
☀️ Test successful - checks-actions |
GuillaumeGomez
added
beta-nominated
Nominated for backporting to the compiler in the beta channel.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Jun 25, 2021
I'd like to see this backported into beta, since it affects the sidebar display of methods on String and Vec in the stdlib docs, and I think will have a substantive impact on people's doc-reading experience if it lands in stable. |
rustbot
added
the
beta-accepted
Accepted for backporting to the compiler in the beta channel.
label
Jul 1, 2021
Merged
cuviper
removed
the
beta-nominated
Nominated for backporting to the compiler in the beta channel.
label
Jul 2, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 2, 2021
[beta] backports - rustfmt: load nested out-of-line mods correctly rust-lang#86424 - Re-add support for parsing (and pretty-printing) inner-attributes in match body rust-lang#85193 - Revert "List trait impls before methods from deref in the sidebar ..." rust-lang#86564 - Revert "Don't load all extern crates unconditionally" rust-lang#85749 r? `@Mark-Simulacrum`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beta-accepted
Accepted for backporting to the compiler in the beta channel.
merged-by-bors
This PR was explicitly merged by bors.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8a05892.
Fixes #85618
r? @jyn514