Improve diagnostics when closure doesn't meet trait bound #80635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
roxelo
changed the title
nikomatsakis
approved these changes
Jan 16, 2021
| for (i, proj) in place.projections.iter().enumerate() { | ||
| match proj.kind { | ||
| HirProjectionKind::Deref => { | ||
| curr_string = format!("*{}", curr_string); |
There was a problem hiding this comment.
Nit: you can use write! macro to append to strings more efficiently -- here is an example
|
📌 Commit b498870 has been approved by `nikomatsakis`` |
bors
added
S-waiting-on-bors
|
Oh, I guess bors saw my command. Well, I think it's fine as is actually so maybe I'll just leave it :) |
|
@bors delegate+ Regardless, I'll make sure bors sees the delegate request. |
|
✌️ @roxelo can now approve this pull request |
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Jan 16, 2021
…mbol, r=nikomatsakis` Improve diagnostics when closure doesn't meet trait bound Improves the diagnostics when closure doesn't meet trait bound by modifying `TypeckResuts::closure_kind_origins` such that `hir::Place` is used instead of `Symbol`. Using `hir::Place` to describe which capture influenced the decision of selecting a trait a closure satisfies to (Fn/FnMut/FnOnce, Copy) allows us to show precise path in the diagnostics when `capture_disjoint_field` feature is enabled. Closes rust-lang/project-rfc-2229/issues/21 r? `@nikomatsakis`
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Jan 17, 2021
…mbol, r=nikomatsakis` Improve diagnostics when closure doesn't meet trait bound Improves the diagnostics when closure doesn't meet trait bound by modifying `TypeckResuts::closure_kind_origins` such that `hir::Place` is used instead of `Symbol`. Using `hir::Place` to describe which capture influenced the decision of selecting a trait a closure satisfies to (Fn/FnMut/FnOnce, Copy) allows us to show precise path in the diagnostics when `capture_disjoint_field` feature is enabled. Closes rust-lang/project-rfc-2229/issues/21 r? ``@nikomatsakis``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 17, 2021
Rollup of 13 pull requests Successful merges: - rust-lang#79298 (correctly deal with late-bound lifetimes in anon consts) - rust-lang#80031 (resolve: Reject ambiguity built-in attr vs different built-in attr) - rust-lang#80201 (Add benchmark and fast path for BufReader::read_exact) - rust-lang#80635 (Improve diagnostics when closure doesn't meet trait bound) - rust-lang#80765 (resolve: Simplify collection of traits in scope) - rust-lang#80932 (Allow downloading LLVM on Windows and MacOS) - rust-lang#80983 (Remove is_dllimport_foreign_item definition from cg_ssa) - rust-lang#81064 (Support non-stage0 check) - rust-lang#81080 (Force vec![] to expression position only) - rust-lang#81082 (BTreeMap: clean up a few more comments) - rust-lang#81084 (Use Option::map instead of open-coding it) - rust-lang#81095 (Use Option::unwrap_or instead of open-coding it) - rust-lang#81107 (Add NonZeroUn::is_power_of_two) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
pickfire
reviewed
Jan 28, 2021
| } | ||
| } | ||
|
|
||
| curr_string.to_string() |
There was a problem hiding this comment.
Why convert String back to String?
There was a problem hiding this comment.
It's not needed, not sure why I did it 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the diagnostics when closure doesn't meet trait bound by modifying
TypeckResuts::closure_kind_originssuch thathir::Placeis used instead ofSymbol. Usinghir::Placeto describe which capture influenced the decision of selecting a trait a closure satisfies to (Fn/FnMut/FnOnce, Copy) allows us to show precise path in the diagnostics whencapture_disjoint_fieldfeature is enabled.Closes rust-lang/project-rfc-2229/issues/21
r? @nikomatsakis