Implement into_keys and into_values for associative maps
#75163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
canova
commented
Aug 4, 2020
canova
force-pushed
the
map_into_keys_values
branch
from
4a7a49d to
c2c7b37
Compare
dtolnay
requested changes
Aug 7, 2020
…oKeys and IntoValues
canova
force-pushed
the
map_into_keys_values
branch
from
c2c7b37 to
16a5217
Compare
dtolnay
reviewed
Aug 7, 2020
dtolnay
reviewed
Aug 7, 2020
3 tasks
|
Thanks for the review! Filed #75294 as the tracking issue and and change the old number to the new in the patch (added two more commits to address them). |
leonardo-m
reviewed
Aug 8, 2020
| /// use std::collections::HashMap; | ||
| /// | ||
| /// let mut map = HashMap::new(); | ||
| /// map.insert("a", 1); |
There was a problem hiding this comment.
Perhaps it's better an example with HashMap<String> instead of HashMap<&str> ?
dtolnay
approved these changes
Aug 8, 2020
|
@bors r+ |
|
📌 Commit 4cd2637 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
tesuji
reviewed
Aug 9, 2020
| @@ -1,3 +1,5 @@ | |||
| // ignore-tidy-filelength | |||
There was a problem hiding this comment.
I think IntoKeys and impls should be moved to a module file to remove this tidy ignore.
mwkmwkmwk
pushed a commit
to mwkmwkmwk/hashbrown
that referenced
this pull request
Sep 20, 2021
This is pretty much a direct copy of rust-lang/rust#75163, aligning the hashbrown API with current std API.
mwkmwkmwk
pushed a commit
to mwkmwkmwk/hashbrown
that referenced
this pull request
Sep 20, 2021
This is pretty much a direct copy of rust-lang/rust#75163, aligning the hashbrown API with current std API.
bors
added a commit
to rust-lang/hashbrown
that referenced
this pull request
Sep 22, 2021
Add into_keys and into_values to HashMap. This is pretty much a direct copy of rust-lang/rust#75163, aligning the hashbrown API with current std API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
into_keysandinto_valuesfor HashMap and BTreeMap types. They are implemented as unstable, undermap_into_keys_valuesfeature.Fixes #55214.
r? @dtolnay