-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up some uses of logging in ui tests #74750
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
cc @JohnTitor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, let's clean-up more things that use obsoleted flags :)
// exec-env:RUST_POISON_ON_FREE=1 |
// rustc-env:RUSTC_BOOTSTRAP_KEY= |
// rustc-env:RUST_NEW_ERROR_FORMAT |
// rustc-env:RUST_NEW_ERROR_FORMAT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we should bless tests but otherwise looks good.
r? @JohnTitor @bors r=JohnTitor |
📌 Commit 86ac65c has been approved by |
@bors rollup |
…r=JohnTitor Clean up some uses of logging in ui tests The removed test can't possibly trigger anything today as we don't have logging in libstd. The `exec-env` flag was mistakenly used for adding env vars to rustc invocations both in test and in the test suite and there were some accidental renames from RUST_LOG to RUSTC_LOG that I reverted.
Rollup of 6 pull requests Successful merges: - rust-lang#74088 (Avoid writes without any data in `Write::write_all_vectored`) - rust-lang#74598 (Fix sync_once_cell_does_not_leak_partially_constructed_boxes) - rust-lang#74750 (Clean up some uses of logging in ui tests) - rust-lang#74783 (python codes cleanup) - rust-lang#74790 (Don't italicize comments in ayu theme) - rust-lang#74799 (Fixed typo in `closure`) Failed merges: r? @ghost
The removed test can't possibly trigger anything today as we don't have logging in libstd.
The
exec-env
flag was mistakenly used for adding env vars to rustc invocations both in test and in the test suite and there were some accidental renames from RUST_LOG to RUSTC_LOG that I reverted.