Avoid writes without any data in Write::write_all_vectored
#74088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| while !bufs.is_empty() { | ||
| match self.write_vectored(bufs) { | ||
| Ok(0) => { | ||
| return Err(Error::new(ErrorKind::WriteZero, "failed to write whole buffer")); | ||
| } | ||
| Ok(n) => bufs = IoSlice::advance(mem::take(&mut bufs), n), |
There was a problem hiding this comment.
It makes me happy this is possible now :)
Thomasdezeeuw
approved these changes
Jul 8, 2020
3 tasks
|
@Thomasdezeeuw @tmiasko This is a triage bump. |
|
r? @KodrAus |
|
I’m not very familiar with this API, but @tmiasko do you expect this unconditional advance to have any perf impact for the more common case of non-empty buffers? |
|
I would expect the impact to be negligible compared to any I/O involved, and changes necessary regardless of the impact. |
KodrAus
reviewed
Jul 26, 2020
Previously, when non-empty sequence of empty IoSlices have been provided to `Write::write_all_vectored`, the buffers would be written as is with `Write::write_vectored` and subsequently the return value `Ok(0)` would be misinterpreted as an error. Avoid writes without any data by advancing the buffers first. This matches the documented behaviour of `Write::write_all_vectored` and is analogous to what happens in `Write::write_all`.
tmiasko
force-pushed
the
write-all-vectored-empty
branch
from
f1bf504 to
7a5d3ab
Compare
|
@bors r+ rollup |
|
📌 Commit 7a5d3ab has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 27, 2020
…=KodrAus Avoid writes without any data in `Write::write_all_vectored` Previously, when non-empty sequence of empty IoSlices have been provided to `Write::write_all_vectored`, the buffers would be written as is with `Write::write_vectored` and subsequently the return value `Ok(0)` would be misinterpreted as an error. Avoid writes without any data by advancing the buffers first. This matches the documented behaviour of `Write::write_all_vectored` and is analogous to what happens in `Write::write_all`.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 27, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#74088 (Avoid writes without any data in `Write::write_all_vectored`) - rust-lang#74598 (Fix sync_once_cell_does_not_leak_partially_constructed_boxes) - rust-lang#74750 (Clean up some uses of logging in ui tests) - rust-lang#74783 (python codes cleanup) - rust-lang#74790 (Don't italicize comments in ayu theme) - rust-lang#74799 (Fixed typo in `closure`) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when non-empty sequence of empty IoSlices have been provided
to
Write::write_all_vectored, the buffers would be written as is withWrite::write_vectoredand subsequently the return valueOk(0)wouldbe misinterpreted as an error.
Avoid writes without any data by advancing the buffers first. This
matches the documented behaviour of
Write::write_all_vectoredand is analogous to what happens in
Write::write_all.