Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing broken link for the Eq trait #73292

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Fixing broken link for the Eq trait #73292

merged 1 commit into from
Jul 10, 2020

Conversation

poliorcetics
Copy link
Contributor

Fixes #73233.

@rust-highfive
Copy link
Collaborator

r? @withoutboats

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2020
@poliorcetics
Copy link
Contributor Author

@rustbot modify labels: T-doc

@rustbot rustbot added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Jun 12, 2020
GuillaumeGomez
GuillaumeGomez requested changes Jun 13, 2020
View reviewed changes
src/libcore/cmp.rs Show resolved Hide resolved
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2020
@JohnCSimon
Copy link
Member

Ping from triage
@poliorcetics - please address the change request from GuillaumeGomez?
Thank you.

@poliorcetics
Copy link
Contributor Author

The suggested change brings back the bug this PR fixes, except if rustdoc itself has been modified in between.

@Muirrum
Copy link
Member

Muirrum commented Jul 9, 2020

@rustbot modify labels to: +S-waiting-on-review -S-waiting-on-author

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 9, 2020
@Dylan-DPC-zz
Copy link

r? @Dylan-DPC

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 9, 2020

📌 Commit 049f6ea has been approved by Dylan-DPC

@Dylan-DPC-zz
Copy link

r? @Dylan-DPC

@bors r+ rollup

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2020
@bors
Copy link
Contributor

bors commented Jul 9, 2020

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: Update cargo #74137

@bors
Copy link
Contributor

bors commented Jul 9, 2020

📌 Commit 049f6ea has been approved by Dylan-DPC

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 9, 2020
@Manishearth
Rollup merge of rust-lang#73292 - poliorcetics:fix-link-in-partialeq,…
39d4e8e 
… r=Dylan-DPC

Fixing broken link for the Eq trait

Fixes rust-lang#73233.
@Manishearth Manishearth mentioned this pull request Jul 9, 2020
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 9, 2020
@Manishearth
Rollup merge of rust-lang#73292 - poliorcetics:fix-link-in-partialeq,…
806cfce 
… r=Dylan-DPC

Fixing broken link for the Eq trait

Fixes rust-lang#73233.
@Manishearth Manishearth mentioned this pull request Jul 9, 2020
Closed
@Manishearth Manishearth mentioned this pull request Jul 9, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 9, 2020
@bors
Auto merge of rust-lang#74195 - Manishearth:rollup-h3m0sl8, r=Manishe…
e59b08e 
…arth

Rollup of 14 pull requests

Successful merges:

 - rust-lang#73292 (Fixing broken link for the Eq trait)
 - rust-lang#73791 (Allow for parentheses after macro intra-doc-links)
 - rust-lang#74070 ( Use for<'tcx> fn pointers in Providers, instead of having Providers<'tcx>.)
 - rust-lang#74077 (Use relative path for local links to primitives)
 - rust-lang#74079 (Eliminate confusing "globals" terminology.)
 - rust-lang#74107 (Hide `&mut self` methods from Deref in sidebar if there are no `DerefMut` impl for the type.)
 - rust-lang#74136 (Fix broken link in rustdocdoc)
 - rust-lang#74137 (Update cargo)
 - rust-lang#74142 (Liballoc use vec instead of vector)
 - rust-lang#74143 (Try remove unneeded ToString import in liballoc slice)
 - rust-lang#74146 (update miri)
 - rust-lang#74150 (Avoid "blacklist")
 - rust-lang#74184 (Add docs for intra-doc-links)
 - rust-lang#74188 (Tweak `::` -> `:` typo heuristic and reduce verbosity)

Failed merges:

 - rust-lang#74122 (Start-up clean-up)
 - rust-lang#74127 (Avoid "whitelist")

r? @ghost
@bors bors merged commit 5fc46fa into rust-lang:master Jul 10, 2020
@poliorcetics poliorcetics deleted the fix-link-in-partialeq branch July 10, 2020 07:01
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez Awaiting requested review from GuillaumeGomez

Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.

Broken link in PartialEq documentation
10 participants
@poliorcetics @rust-highfive @JohnCSimon @Muirrum @Dylan-DPC-zz @bors @GuillaumeGomez @cuviper @withoutboats @rustbot