Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct await span for async-await error reporting #71203

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Correct await span for async-await error reporting #71203

merged 2 commits into from
Apr 22, 2020

Conversation

csmoe
Copy link
Member

@csmoe csmoe commented Apr 16, 2020

Closes #71137
r? @tmandry

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2020
@csmoe csmoe force-pushed the issue-71137 branch 5 times, most recently from e0f716d to 74b025c Compare April 17, 2020 02:49
@rokob rokob mentioned this pull request Apr 17, 2020
Merged
@tmandry
Copy link
Member

tmandry commented Apr 21, 2020

@bors delegate=csmoe

Thanks for the fix! r=me after nit

@bors
Copy link
Contributor

bors commented Apr 21, 2020

✌️ @csmoe can now approve this pull request

@tmandry tmandry added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2020
@csmoe
Copy link
Member Author

csmoe commented Apr 22, 2020

@bors r+
cc @tmandry

@bors
Copy link
Contributor

bors commented Apr 22, 2020

📌 Commit 00d12ef has been approved by csmoe

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 22, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 22, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2020
@bors
Auto merge of rust-lang#71424 - Dylan-DPC:rollup-iunh61a, r=Dylan-DPC
00f677d 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#70970 (Detect mistyped associated consts in `Instance::resolve`.)
 - rust-lang#71203 (Correct await span for async-await error reporting)
 - rust-lang#71214 (Add error code for inner doc error)
 - rust-lang#71337 (Moving all rustdoc-ui tests to check-pass)
 - rust-lang#71412 (Clarify unused_doc_comments note on macro invocations)
 - rust-lang#71414 (More diagnostic items for Clippy usage)

Failed merges:

r? @ghost
@bors bors merged commit 7b1ce6e into rust-lang:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmandry tmandry tmandry left review comments

Assignees

@tmandry tmandry

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve await error messaging for trait obligations
4 participants
@csmoe @tmandry @bors @rust-highfive