-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve MinGW detection when cross compiling #69549
Conversation
r? @kennytm (rust_highfive has picked a reviewer for you, use r? to override) |
@bors try |
⌛ Trying commit f0f44aeccb0136fcaf7bd2dfe4132d7ca976b2e9 with merge 26e9f14ccca6fe334704d3d7dc5fdbfa365323b2... |
☀️ Try build successful - checks-azure |
Co-Authored-By: kennytm <[email protected]>
Tested both i686 and x86_64 builds, they work as good as before on Windows. |
@bors r+ rollup |
📌 Commit cdb6955 has been approved by |
Rollup of 7 pull requests Successful merges: - #69397 (bootstrap: Remove commit hash from LLVM version suffix to avoid rebuilds) - #69549 (Improve MinGW detection when cross compiling ) - #69562 (Don't `bug` when taking discriminant of generator during dataflow) - #69579 (parser: Remove `Parser::prev_span`) - #69580 (use .copied() instead of .map(|x| *x) on iterators) - #69583 (Do not ICE on invalid type node after parse recovery) - #69605 (Use `opt_def_id()` over `def_id()`) Failed merges: r? @ghost
Official mingw-w64 builds, MSYS2 and LLVM MinGW provide both
gcc.exe
and$ARCH-w64-mingw32-gcc.exe
so they should not regress but I included CI changes to verify it though@bors try
(I don't have permission).This change will come handy when cross compiling from Linux or Cygwin since they use
gcc
as native compiler and$ARCH-w64-mingw32-gcc.exe
for MinGW. This means users will no longer have to override the linker.