Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyword docs for else and inkeyword docs for else and in. #67749

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

gilescope
Copy link
Contributor

First cut of else and in keyword docs. Comments and suggestions more than welcome.

@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 31, 2019
@Dylan-DPC-zz
Copy link

r? @Dylan-DPC

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-31T08:46:37.4294910Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-31T08:46:37.4503077Z ##[command]git config gc.auto 0
2019-12-31T08:46:37.4562202Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-31T08:46:37.4615674Z ##[command]git config --get-all http.proxy
2019-12-31T08:46:37.4774022Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67749/merge:refs/remotes/pull/67749/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Dylan-DPC-zz Dylan-DPC-zz added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2019
@JohnCSimon
Copy link
Member

Ping from triage:
@gilescope - can you address the build failure in this PR, please? Thank you.

@hdhoang
Copy link
Contributor

hdhoang commented Feb 6, 2020

ping from triage @gilescope, any updates on this? The previous build log has been removed already so I can't check further details

@gilescope
Copy link
Contributor Author

Sorry for the delay. Will get on to it.

Sent with GitHawk

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-02-12T06:15:25.0779222Z ========================== Starting Command Output ===========================
2020-02-12T06:15:25.0781069Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/a0a4594f-9651-4d8a-86d6-02b6f1e24336.sh
2020-02-12T06:15:25.0781103Z 
2020-02-12T06:15:25.0783515Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-12T06:15:25.0789619Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67749/merge to s
2020-02-12T06:15:25.0791017Z Task         : Get sources
2020-02-12T06:15:25.0791048Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-12T06:15:25.0791079Z Version      : 1.0.0
2020-02-12T06:15:25.0791117Z Author       : Microsoft
---
2020-02-12T06:15:26.1359195Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-12T06:15:26.1372022Z ##[command]git config gc.auto 0
2020-02-12T06:15:26.1376369Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-12T06:15:26.1379891Z ##[command]git config --get-all http.proxy
2020-02-12T06:15:26.1390632Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67749/merge:refs/remotes/pull/67749/merge
---
2020-02-12T07:15:55.8433623Z .................................................................................................... 1700/9631
2020-02-12T07:16:00.6015515Z .................................................................................................... 1800/9631
2020-02-12T07:16:12.3471836Z ..............................i..................................................................... 1900/9631
2020-02-12T07:16:19.9584908Z .................................................................................................... 2000/9631
2020-02-12T07:16:33.9982718Z ....................iiiii........................................................................... 2100/9631
2020-02-12T07:16:43.4569776Z .................................................................................................... 2300/9631
2020-02-12T07:16:45.8333028Z .................................................................................................... 2400/9631
2020-02-12T07:16:50.3777347Z .................................................................................................... 2500/9631
2020-02-12T07:17:10.9675182Z .................................................................................................... 2600/9631
---
2020-02-12T07:19:43.9875221Z .......................................................................i...............i............ 4900/9631
2020-02-12T07:19:51.6329943Z .................................................................................................... 5000/9631
2020-02-12T07:19:59.6745790Z .................................................................................................... 5100/9631
2020-02-12T07:20:04.2964791Z .............i...................................................................................... 5200/9631
2020-02-12T07:20:15.7941002Z .......................................................................................ii.ii........ 5300/9631
2020-02-12T07:20:19.8675303Z i...i............................................................................................... 5400/9631
2020-02-12T07:20:31.8934287Z .................................................................................................... 5600/9631
2020-02-12T07:20:40.4838099Z ............................................................................i....................... 5700/9631
2020-02-12T07:20:47.8800909Z .................................................................................................... 5800/9631
2020-02-12T07:20:54.3222481Z .................................................................................................... 5900/9631
2020-02-12T07:20:54.3222481Z .................................................................................................... 5900/9631
2020-02-12T07:21:04.2918405Z ....................................................................ii...i..ii...........i.......... 6000/9631
2020-02-12T07:21:25.4208395Z .................................................................................................... 6200/9631
2020-02-12T07:21:32.9454385Z .................................................................................................... 6300/9631
2020-02-12T07:21:40.8157447Z ................................................................................................i..i 6400/9631
2020-02-12T07:21:59.0225890Z i................................................................................................... 6500/9631
---
2020-02-12T07:24:03.3871194Z .................................................................................................... 7600/9631
2020-02-12T07:24:07.7036923Z .................................................................................................... 7700/9631
2020-02-12T07:24:13.6266970Z .................................................................................................... 7800/9631
2020-02-12T07:24:21.6917583Z .................................................................................................... 7900/9631
2020-02-12T07:24:30.1677415Z .........................................................................iiiiiii.i.................. 8000/9631
2020-02-12T07:24:46.3949528Z .............i......i............................................................................... 8200/9631
2020-02-12T07:24:51.7709827Z .................................................................................................... 8300/9631
2020-02-12T07:25:05.1075625Z .................................................................................................... 8400/9631
2020-02-12T07:25:14.7634627Z .................................................................................................... 8500/9631
---
2020-02-12T07:27:42.1465664Z  finished in 7.314
2020-02-12T07:27:42.1651473Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-12T07:27:42.3771928Z 
2020-02-12T07:27:42.3772110Z running 178 tests
2020-02-12T07:27:45.4031270Z iiii......i...........ii..iiii...i....i...........i............i..i..................i....i......... 100/178
2020-02-12T07:27:47.7879033Z ...i.i.i...iii..iiiiiiiiiiiiiiii.......................iii............ii......
2020-02-12T07:27:47.7880045Z 
2020-02-12T07:27:47.7885278Z  finished in 5.623
2020-02-12T07:27:47.8062623Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-12T07:27:47.9764387Z 
---
2020-02-12T07:27:50.2950434Z  finished in 2.118
2020-02-12T07:27:50.2954684Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-12T07:27:50.2954903Z 
2020-02-12T07:27:50.2955366Z running 9 tests
2020-02-12T07:27:50.2956523Z iiiiiiiii
2020-02-12T07:27:50.2957317Z 
2020-02-12T07:27:50.2957528Z  finished in 0.163
2020-02-12T07:27:50.3290013Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-12T07:27:50.3290088Z 
---
2020-02-12T07:28:10.5313089Z  finished in 20.402
2020-02-12T07:28:11.0675889Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-12T07:28:11.5485520Z 
2020-02-12T07:28:11.5486242Z running 116 tests
2020-02-12T07:28:24.7757792Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii..........i.....i..i.......ii.i.ii. 100/116
2020-02-12T07:28:26.5852532Z ....iiii.....ii.
2020-02-12T07:28:26.5853049Z 
2020-02-12T07:28:26.5857811Z  finished in 15.519
2020-02-12T07:28:26.5862915Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-12T07:28:26.5863545Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-02-12T07:42:21.6372545Z 
2020-02-12T07:42:21.6373407Z    Doc-tests core
2020-02-12T07:42:26.5912749Z 
2020-02-12T07:42:26.5914942Z running 2471 tests
2020-02-12T07:42:35.5304775Z ......iiiii......................................................................................... 100/2471
2020-02-12T07:42:44.2885262Z ..................................................................................ii................ 200/2471
2020-02-12T07:43:04.8375135Z .................i.................................................................................. 400/2471
2020-02-12T07:43:04.8375135Z .................i.................................................................................. 400/2471
2020-02-12T07:43:14.3990976Z ......................................................................i..i..................iiii.... 500/2471
2020-02-12T07:43:30.5165678Z .................................................................................................... 700/2471
2020-02-12T07:43:38.9270997Z .................................................................................................... 800/2471
2020-02-12T07:43:47.2543238Z .................................................................................................... 900/2471
2020-02-12T07:43:55.6283278Z .................................................................................................... 1000/2471
---
2020-02-12T07:47:31.7665778Z 
2020-02-12T07:47:31.7668506Z running 1011 tests
2020-02-12T07:47:49.7013972Z i................................................................................................... 100/1011
2020-02-12T07:47:59.4546114Z .................................................................................................... 200/1011
2020-02-12T07:48:06.3976341Z ..................iii......i......i...i......i...................................................... 300/1011
2020-02-12T07:48:11.3057158Z .................................................................................................... 400/1011
2020-02-12T07:48:17.8460632Z ............................................i.F..i.....................................ii........... 500/1011
2020-02-12T07:48:30.1040114Z .................................................................................................... 700/1011
2020-02-12T07:48:30.1040114Z .................................................................................................... 700/1011
2020-02-12T07:48:36.6986398Z .....................................iiii........................................................... 800/1011
2020-02-12T07:48:50.5174438Z .................................................................................................... 900/1011
2020-02-12T07:48:57.1515791Z ...........................................................iiii..................................... 1000/1011
2020-02-12T07:48:57.6364074Z failures:
2020-02-12T07:48:57.6364112Z 
2020-02-12T07:48:57.6364112Z 
2020-02-12T07:48:57.6372806Z ---- keyword_docs.rs - else_keyword (line 248) stdout ----
2020-02-12T07:48:57.6372885Z error: expected `;`, found ``}``
2020-02-12T07:48:57.6373344Z   --> keyword_docs.rs:258:2
2020-02-12T07:48:57.6373742Z 13 | }
2020-02-12T07:48:57.6373742Z 13 | }
2020-02-12T07:48:57.6373951Z    |  ^ help: add `;` here
2020-02-12T07:48:57.6374869Z    | - unexpected token
2020-02-12T07:48:57.6374907Z 
2020-02-12T07:48:57.6374953Z error: aborting due to previous error
2020-02-12T07:48:57.6374983Z 
---
2020-02-12T07:48:57.6588089Z   local time: Wed Feb 12 07:48:57 UTC 2020
2020-02-12T07:48:57.7632954Z   network time: Wed, 12 Feb 2020 07:48:57 GMT
2020-02-12T07:48:57.7635450Z == end clock drift check ==
2020-02-12T07:48:58.1593860Z 
2020-02-12T07:48:58.1701616Z ##[error]Bash exited with code '1'.
2020-02-12T07:48:58.1724638Z ##[section]Finishing: Run build
2020-02-12T07:48:58.1752855Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67749/merge to s
2020-02-12T07:48:58.1755452Z Task         : Get sources
2020-02-12T07:48:58.1755500Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-12T07:48:58.1755567Z Version      : 1.0.0
2020-02-12T07:48:58.1755609Z Author       : Microsoft
2020-02-12T07:48:58.1755609Z Author       : Microsoft
2020-02-12T07:48:58.1755657Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-02-12T07:48:58.1755727Z ==============================================================================
2020-02-12T07:48:58.6137687Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-02-12T07:48:58.6186335Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/67749/merge to s
2020-02-12T07:48:58.6308224Z Cleaning up task key
2020-02-12T07:48:58.6309072Z Start cleaning up orphan processes.
2020-02-12T07:48:58.6414425Z Terminate orphan process: pid (5419) (python)
2020-02-12T07:48:58.6794722Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-02-12T08:33:47.0901095Z ========================== Starting Command Output ===========================
2020-02-12T08:33:47.0902654Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/cfbdba93-3365-49a2-b8c8-63f439f11515.sh
2020-02-12T08:33:47.0902708Z 
2020-02-12T08:33:47.0905486Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-12T08:33:47.0909914Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67749/merge to s
2020-02-12T08:33:47.0912224Z Task         : Get sources
2020-02-12T08:33:47.0912258Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-12T08:33:47.0912290Z Version      : 1.0.0
2020-02-12T08:33:47.0912358Z Author       : Microsoft
---
2020-02-12T08:33:47.9778879Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-12T08:33:47.9861428Z ##[command]git config gc.auto 0
2020-02-12T08:33:47.9936565Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-12T08:33:47.9994582Z ##[command]git config --get-all http.proxy
2020-02-12T08:33:48.0133123Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67749/merge:refs/remotes/pull/67749/merge
---
2020-02-12T09:33:15.7386652Z .................................................................................................... 1700/9631
2020-02-12T09:33:20.6124020Z .................................................................................................... 1800/9631
2020-02-12T09:33:32.5263903Z ..............................i..................................................................... 1900/9631
2020-02-12T09:33:40.3672159Z .................................................................................................... 2000/9631
2020-02-12T09:33:54.7756090Z ....................iiiii........................................................................... 2100/9631
2020-02-12T09:34:04.6431855Z .................................................................................................... 2300/9631
2020-02-12T09:34:06.9632501Z .................................................................................................... 2400/9631
2020-02-12T09:34:11.6389524Z .................................................................................................... 2500/9631
2020-02-12T09:34:32.6529289Z .................................................................................................... 2600/9631
---
2020-02-12T09:37:07.5885338Z .......................................................................i...............i............ 4900/9631
2020-02-12T09:37:15.1397679Z .................................................................................................... 5000/9631
2020-02-12T09:37:23.0613958Z .................................................................................................... 5100/9631
2020-02-12T09:37:27.6170359Z .............i...................................................................................... 5200/9631
2020-02-12T09:37:38.5601105Z .......................................................................................ii.ii........ 5300/9631
2020-02-12T09:37:42.3919274Z i...i............................................................................................... 5400/9631
2020-02-12T09:37:53.8912003Z .................................................................................................... 5600/9631
2020-02-12T09:38:02.2422262Z ............................................................................i....................... 5700/9631
2020-02-12T09:38:09.5657387Z .................................................................................................... 5800/9631
2020-02-12T09:38:15.7731988Z .................................................................................................... 5900/9631
2020-02-12T09:38:15.7731988Z .................................................................................................... 5900/9631
2020-02-12T09:38:25.6033652Z ....................................................................ii...i..ii...........i.......... 6000/9631
2020-02-12T09:38:46.5837557Z .................................................................................................... 6200/9631
2020-02-12T09:38:53.9686054Z .................................................................................................... 6300/9631
2020-02-12T09:39:01.8353041Z ................................................................................................i..i 6400/9631
2020-02-12T09:39:15.5621713Z i................................................................................................... 6500/9631
---
2020-02-12T09:41:18.4421440Z .................................................................................................... 7600/9631
2020-02-12T09:41:22.9813809Z .................................................................................................... 7700/9631
2020-02-12T09:41:29.1042313Z .................................................................................................... 7800/9631
2020-02-12T09:41:37.1140186Z .................................................................................................... 7900/9631
2020-02-12T09:41:45.5003869Z .........................................................................iiiiiii.i.................. 8000/9631
2020-02-12T09:42:01.6718052Z .............i......i............................................................................... 8200/9631
2020-02-12T09:42:06.9867461Z .................................................................................................... 8300/9631
2020-02-12T09:42:20.2279346Z .................................................................................................... 8400/9631
2020-02-12T09:42:29.7384567Z .................................................................................................... 8500/9631
---
2020-02-12T09:44:52.0970508Z  finished in 7.145
2020-02-12T09:44:52.1150675Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-12T09:44:52.3247395Z 
2020-02-12T09:44:52.3247587Z running 178 tests
2020-02-12T09:44:55.1600966Z iiii......i...........ii..iiii...i....i...........i............i..i..................i....i......... 100/178
2020-02-12T09:44:57.4674129Z ...i.i.i...iii..iiiiiiiiiiiiiiii.......................iii............ii......
2020-02-12T09:44:57.4675299Z 
2020-02-12T09:44:57.4680642Z  finished in 5.353
2020-02-12T09:44:57.4848316Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-12T09:44:57.6468365Z 
---
2020-02-12T09:45:00.3816824Z  finished in 2.051
2020-02-12T09:45:00.3818765Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-12T09:45:00.3819162Z 
2020-02-12T09:45:00.3819314Z running 9 tests
2020-02-12T09:45:00.3819890Z iiiiiiiii
2020-02-12T09:45:00.3820435Z 
2020-02-12T09:45:00.3820549Z  finished in 0.160
2020-02-12T09:45:00.3820897Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-12T09:45:00.3821050Z 
---
2020-02-12T09:45:20.3854513Z  finished in 19.689
2020-02-12T09:45:20.3861183Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-12T09:45:20.3861230Z 
2020-02-12T09:45:20.3861272Z running 116 tests
2020-02-12T09:45:32.9938605Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii..........i.....i..i.......ii.i.ii. 100/116
2020-02-12T09:45:34.7587106Z ....iiii.....ii.
2020-02-12T09:45:34.7589342Z 
2020-02-12T09:45:34.7590195Z  finished in 15.316
2020-02-12T09:45:34.7600701Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-12T09:45:34.7601615Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-02-12T09:59:06.6126800Z 
2020-02-12T09:59:06.6127635Z    Doc-tests core
2020-02-12T09:59:11.0588126Z 
2020-02-12T09:59:11.0588874Z running 2471 tests
2020-02-12T09:59:19.8188733Z ......iiiii......................................................................................... 100/2471
2020-02-12T09:59:28.4435843Z ..................................................................................ii................ 200/2471
2020-02-12T09:59:48.8188395Z .................i.................................................................................. 400/2471
2020-02-12T09:59:48.8188395Z .................i.................................................................................. 400/2471
2020-02-12T09:59:58.3830529Z ......................................................................i..i..................iiii.... 500/2471
2020-02-12T10:00:14.1503198Z .................................................................................................... 700/2471
2020-02-12T10:00:22.4151281Z .................................................................................................... 800/2471
2020-02-12T10:00:30.7466728Z .................................................................................................... 900/2471
2020-02-12T10:00:39.1149965Z .................................................................................................... 1000/2471
---
2020-02-12T10:04:10.8971079Z 
2020-02-12T10:04:10.8971735Z running 1011 tests
2020-02-12T10:04:28.6401909Z i................................................................................................... 100/1011
2020-02-12T10:04:38.5193323Z .................................................................................................... 200/1011
2020-02-12T10:04:45.2331714Z ..................iii......i......i...i......i...................................................... 300/1011
2020-02-12T10:04:56.5948695Z ............................................i....i.....................................ii........... 500/1011
2020-02-12T10:05:03.5161842Z .................................................................................................... 600/1011
2020-02-12T10:05:08.6076173Z .................................................................................................... 700/1011
2020-02-12T10:05:08.6076173Z .................................................................................................... 700/1011
2020-02-12T10:05:15.2187580Z .....................................iiii........................................................... 800/1011
2020-02-12T10:05:28.8930065Z .................................................................................................... 900/1011
2020-02-12T10:05:35.4250388Z ...........................................................iiii..................................... 1000/1011
2020-02-12T10:05:35.8312727Z test result: ok. 991 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out
2020-02-12T10:05:35.8312832Z 
2020-02-12T10:05:35.8423850Z  finished in 166.074
2020-02-12T10:05:35.8444214Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-02-12T10:24:38.2298633Z Rustbook (x86_64-unknown-linux-gnu) - edition-guide
2020-02-12T10:24:38.6233305Z Building stage0 tool linkchecker (x86_64-unknown-linux-gnu)
2020-02-12T10:24:38.7715315Z    Compiling linkchecker v0.1.0 (/checkout/src/tools/linkchecker)
2020-02-12T10:24:40.3081688Z     Finished release [optimized] target(s) in 1.68s
2020-02-12T10:24:44.4768585Z std/keyword.in.html:5: broken link - std/ops/struct.RangeExclusive.html
2020-02-12T10:24:48.0308779Z thread 'main' panicked at 'found some broken links', src/tools/linkchecker/main.rs:43:9
2020-02-12T10:24:48.0310235Z 
2020-02-12T10:24:48.0310269Z 
2020-02-12T10:24:48.0310816Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
2020-02-12T10:24:48.0311143Z expected success, got: exit code: 101
---
2020-02-12T10:24:48.0320561Z   local time: Wed Feb 12 10:24:47 UTC 2020
2020-02-12T10:24:48.0320833Z   network time: Wed, 12 Feb 2020 10:24:47 GMT
2020-02-12T10:24:48.0321003Z == end clock drift check ==
2020-02-12T10:24:49.3559088Z 
2020-02-12T10:24:49.3647419Z ##[error]Bash exited with code '1'.
2020-02-12T10:24:49.3669338Z ##[section]Finishing: Run build
2020-02-12T10:24:49.3694722Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67749/merge to s
2020-02-12T10:24:49.3696417Z Task         : Get sources
2020-02-12T10:24:49.3696468Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-12T10:24:49.3696504Z Version      : 1.0.0
2020-02-12T10:24:49.3696535Z Author       : Microsoft
2020-02-12T10:24:49.3696535Z Author       : Microsoft
2020-02-12T10:24:49.3696587Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-02-12T10:24:49.3696626Z ==============================================================================
2020-02-12T10:24:49.8002192Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-02-12T10:24:49.8011624Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/67749/merge to s
2020-02-12T10:24:49.8136146Z Cleaning up task key
2020-02-12T10:24:49.8136796Z Start cleaning up orphan processes.
2020-02-12T10:24:49.8249461Z Terminate orphan process: pid (3544) (python)
2020-02-12T10:24:49.8516340Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@gilescope
Copy link
Contributor Author

@Dylan-DPC it's building now - are we happy with the contents or are there any suggestions on how we can improve it?

@Dylan-DPC-zz
Copy link

Oops didn't see this for some reason. Let me review it. Looks good to me

@gilescope
Copy link
Contributor Author

@Dylan-DPC how's it looking? Any suggestions or is this landable?

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 18, 2020

📋 Looks like this PR is still in progress, ignoring approval.

Hint: Remove WIP from this PR's title when it is ready for review.

@Dylan-DPC-zz Dylan-DPC-zz changed the title WIP: keyword docs for else and inkeyword docs for else and in. keyword docs for else and inkeyword docs for else and in. Mar 18, 2020
@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 18, 2020

📌 Commit a113609 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 18, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 18, 2020
keyword docs for else and inkeyword docs for else and in.

First cut of else and in keyword docs. Comments and suggestions more than welcome.
Centril added a commit to Centril/rust that referenced this pull request Mar 18, 2020
keyword docs for else and inkeyword docs for else and in.

First cut of else and in keyword docs. Comments and suggestions more than welcome.
Centril added a commit to Centril/rust that referenced this pull request Mar 18, 2020
keyword docs for else and inkeyword docs for else and in.

First cut of else and in keyword docs. Comments and suggestions more than welcome.
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Mar 18, 2020
Rollup of 10 pull requests

Successful merges:

 - rust-lang#67749 (keyword docs for else and inkeyword docs for else and in.)
 - rust-lang#69139 (clean up E0308 explanation)
 - rust-lang#69189 (Erase regions in writeback)
 - rust-lang#69837 (Use smaller discriminants for generators)
 - rust-lang#69838 (Expansion-driven outline module parsing)
 - rust-lang#69839 (Miri error reform)
 - rust-lang#69899 (Make methods declared by `newtype_index` macro `const`)
 - rust-lang#69920 (Remove some imports to the rustc crate)
 - rust-lang#70075 (Fix repr pretty display)
 - rust-lang#70106 (Tidy: fix running rustfmt twice)

Failed merges:

 - rust-lang#70051 (Allow `hir().find` to return `None`)
 - rust-lang#70074 (Expand: nix all fatal errors)

r? @ghost
@bors bors merged commit 5610684 into rust-lang:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants