Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the testcases for VxWorks #66998

Merged
merged 1 commit into from
Dec 6, 2019
Merged

Conversation

BaoshanPang
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 3, 2019
@BaoshanPang
Copy link
Contributor Author

BaoshanPang commented Dec 3, 2019

cc @n-salim
cc @UmeshKalappa

@alexcrichton
Copy link
Member

I wanted to write a comment again which echoes something I think I've said previously, which is that keeping the test suite running for vxworks is going to be very difficult and unfortunately probably cause a bit of a burden on us as a project. There's already been a good number of PRs adding // ignore-vxworks annotations and this is starting to add assertions in the test suite itself.

I'm generally ok rubber-stamping these for now, but there continues to be no guarantee that they won't regress quickly. If we write new tests, for example, there's no guarantee they'll work on vxworks. Additionally I think we'll still reserve the right to clean up these tests and back out the annotations if we think they cause too much overhead in managing the tests for other platforms.

To confirm, is all that still ok?

@BaoshanPang
Copy link
Contributor Author

I wanted to write a comment again which echoes something I think I've said previously, which is that keeping the test suite running for vxworks is going to be very difficult and unfortunately probably cause a bit of a burden on us as a project. There's already been a good number of PRs adding // ignore-vxworks annotations and this is starting to add assertions in the test suite itself.

I'm generally ok rubber-stamping these for now, but there continues to be no guarantee that they won't regress quickly. If we write new tests, for example, there's no guarantee they'll work on vxworks. Additionally I think we'll still reserve the right to clean up these tests and back out the annotations if we think they cause too much overhead in managing the tests for other platforms.

To confirm, is all that still ok?

Sure. We appriciate the support from you and the community. Fixing the test case makes us easier in term of working on rust for vxWorks, but if that cause too much overhead for the project we will be thinking about another way to work around it.

@alexcrichton
Copy link
Member

@bors: r+

Ok, I can keep rubber stamping while I'm able in that case!

@bors
Copy link
Contributor

bors commented Dec 4, 2019

📌 Commit dc1a428 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Dec 6, 2019
bors added a commit that referenced this pull request Dec 6, 2019
Rollup of 11 pull requests

Successful merges:

 - #66846 (Make try_mark_previous_green aware of cycles.)
 - #66959 (Remove potential cfgs duplicates)
 - #66988 (Fix angle bracket formatting when dumping MIR debug vars)
 - #66998 (Modified the testcases for VxWorks)
 - #67008 (rustdoc: Add test for fixed issue)
 - #67023 (SGX: Fix target linker used by bootstrap)
 - #67033 (Migrate to LLVM{Get,Set}ValueName2)
 - #67049 (Simplify {IoSlice, IoSliceMut}::advance examples and tests)
 - #67054 (codegen "unreachable" for invalid SetDiscriminant)
 - #67081 (Fix Query type docs)
 - #67085 (Remove boxed closures in address parser.)

Failed merges:

r? @ghost
@bors bors merged commit dc1a428 into rust-lang:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants