-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified the testcases for VxWorks #66998
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
cc @n-salim |
2836338
to
dc1a428
Compare
I wanted to write a comment again which echoes something I think I've said previously, which is that keeping the test suite running for vxworks is going to be very difficult and unfortunately probably cause a bit of a burden on us as a project. There's already been a good number of PRs adding I'm generally ok rubber-stamping these for now, but there continues to be no guarantee that they won't regress quickly. If we write new tests, for example, there's no guarantee they'll work on vxworks. Additionally I think we'll still reserve the right to clean up these tests and back out the annotations if we think they cause too much overhead in managing the tests for other platforms. To confirm, is all that still ok? |
Sure. We appriciate the support from you and the community. Fixing the test case makes us easier in term of working on rust for vxWorks, but if that cause too much overhead for the project we will be thinking about another way to work around it. |
@bors: r+ Ok, I can keep rubber stamping while I'm able in that case! |
📌 Commit dc1a428 has been approved by |
Modified the testcases for VxWorks
Rollup of 11 pull requests Successful merges: - #66846 (Make try_mark_previous_green aware of cycles.) - #66959 (Remove potential cfgs duplicates) - #66988 (Fix angle bracket formatting when dumping MIR debug vars) - #66998 (Modified the testcases for VxWorks) - #67008 (rustdoc: Add test for fixed issue) - #67023 (SGX: Fix target linker used by bootstrap) - #67033 (Migrate to LLVM{Get,Set}ValueName2) - #67049 (Simplify {IoSlice, IoSliceMut}::advance examples and tests) - #67054 (codegen "unreachable" for invalid SetDiscriminant) - #67081 (Fix Query type docs) - #67085 (Remove boxed closures in address parser.) Failed merges: r? @ghost
No description provided.