Point at opaque and closure type definitions in type errors #66463

estebank · 2019-11-16T02:53:55Z

Fixes #57266, fixes #67117.

src/test/ui/async-await/suggest-missing-await.stderr

src/test/ui/impl-trait/equality2.stderr

src/librustc/infer/error_reporting/mod.rs

Centril · 2019-11-16T04:17:38Z

r? @Centril

src/test/ui/async-await/suggest-missing-await.stderr

Aaron1011 · 2020-01-01T10:19:39Z

src/test/ui/impl-trait/equality2.stderr

@@ -25,6 +31,12 @@ LL |     let _: i32 = Leak::leak(hide(0_i32));
 error[E0308]: mismatched types
  --> $DIR/equality2.rs:38:10
   |
+LL | fn hide<T: Foo>(x: T) -> impl Foo {


I think it would be a good idea to add an additional explanation when the mismatch is due to the substs of an opaque type, as the current message seems quite self-contradictory. Maybe something like:

the expected opaque type (created from foo::<u32>) the found opaque type (created from foo::<i32>) note: a distinct opaque type is created for each distinct set of generic arguments provided to `foo`

I'm thinking about how to properly tackle this case. It is certainly confusing, but I would like to tackle it specifically and not as part of this PR. Would you mind filing a follow up ticket for this with your thoughts, @Aaron1011?

I think the wording you present is reasonable, but might require some tweaking, as the created from foo::<_> messages might be hard to accomplish.

Opened #68020

src/librustc/traits/error_reporting.rs

src/librustc/infer/error_reporting/mod.rs

estebank · 2020-01-08T17:41:13Z

Addressed the comments and rebased.

Centril · 2020-01-09T22:43:26Z

@bors r+

bors · 2020-01-09T22:43:28Z

📌 Commit 33ae322 has been approved by Centril

…e-types, r=Centril Point at opaque and closure type definitions in type errors Fixes rust-lang#57266, fixes rust-lang#67117.

@ghost

Rollup of 6 pull requests Successful merges: - #66463 (Point at opaque and closure type definitions in type errors) - #67501 (Reduce special treatment for zsts) - #67820 (Parse the syntax described in RFC 2632) - #67922 (rustc_ast_lowering: misc cleanup & rustc dep reductions) - #68071 (Extend support of `_` in type parameters) - #68073 (expect `fn` after `const unsafe` / `const extern`) Failed merges: r? @ghost

rust-highfive assigned petrochenkov Nov 16, 2019

This comment has been minimized.

Sign in to view

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 16, 2019

estebank changed the title ~~Point at opaque and closure type definitions in type errors~~ [WIP] Point at opaque and closure type definitions in type errors Nov 16, 2019

This comment has been minimized.

Sign in to view

Centril reviewed Nov 16, 2019

View reviewed changes

rust-highfive assigned Centril and unassigned petrochenkov Nov 16, 2019

Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2019

This comment has been minimized.

Sign in to view

Aaron1011 mentioned this pull request Dec 11, 2019

Print better auto-trait diagnostics when opaque return type is involved #67117

Closed

hdhoang added A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Dec 12, 2019

This comment has been minimized.

Sign in to view

estebank changed the title ~~[WIP] Point at opaque and closure type definitions in type errors~~ Point at opaque and closure type definitions in type errors Dec 15, 2019

estebank force-pushed the point-at-closure-and-opaque-types branch 2 times, most recently from f0219b0 to bbab797 Compare December 16, 2019 06:20

Centril reviewed Dec 16, 2019

View reviewed changes

src/test/ui/async-await/suggest-missing-await.stderr Outdated Show resolved Hide resolved

estebank force-pushed the point-at-closure-and-opaque-types branch from 4ebcc3f to 6678094 Compare December 16, 2019 19:44

This comment has been minimized.

Sign in to view

Aaron1011 reviewed Jan 1, 2020

View reviewed changes

estebank force-pushed the point-at-closure-and-opaque-types branch from 6678094 to 3efc92a Compare January 8, 2020 00:58

Centril reviewed Jan 8, 2020

View reviewed changes

src/librustc/traits/error_reporting.rs Outdated Show resolved Hide resolved

Centril reviewed Jan 8, 2020

View reviewed changes

src/librustc/infer/error_reporting/mod.rs Outdated Show resolved Hide resolved

src/librustc/infer/error_reporting/mod.rs Show resolved Hide resolved

src/librustc/infer/error_reporting/mod.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Point at opaque and closure type definitions in type errors

9c0000c

estebank added 7 commits January 8, 2020 09:29

review comments

c556151

Point at the def span of trait refs E0277

0dcdbae

review comment: wording

542be6f

review comments

b522ba0

review comments

ffcdbad

reduce code duplication

705e087

remove unnecessary Debug

33ae322

estebank force-pushed the point-at-closure-and-opaque-types branch from 0c03db6 to 33ae322 Compare January 8, 2020 17:30

estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 8, 2020

Aaron1011 mentioned this pull request Jan 8, 2020

Diagnostic should explain that 'impl trait' captures generic parameters #68020

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 9, 2020

Centril mentioned this pull request Jan 10, 2020

Rollup of 7 pull requests #68077

Closed

Centril mentioned this pull request Jan 10, 2020

Rollup of 6 pull requests #68078

Merged

bors merged commit 33ae322 into rust-lang:master Jan 10, 2020

pnkfelix mentioned this pull request Feb 20, 2020

beta regression: ICE on Tried to access field 0 of union Layout #69191

Closed

nellshamrell mentioned this pull request Jan 10, 2021

Note when opaque future from async fn is involved in a type mismatch is unclear #80658

Closed

estebank deleted the point-at-closure-and-opaque-types branch November 9, 2023 05:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Point at opaque and closure type definitions in type errors #66463

Point at opaque and closure type definitions in type errors #66463

estebank commented Nov 16, 2019 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

Centril commented Nov 16, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Aaron1011 Jan 1, 2020 •

edited

Loading

estebank Jan 8, 2020

Aaron1011 Jan 8, 2020

This comment has been minimized.

estebank commented Jan 8, 2020 •

edited

Loading

Centril commented Jan 9, 2020

bors commented Jan 9, 2020

Point at opaque and closure type definitions in type errors #66463

Point at opaque and closure type definitions in type errors #66463

Conversation

estebank commented Nov 16, 2019 • edited Loading

This comment has been minimized.

This comment has been minimized.

Centril commented Nov 16, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Aaron1011 Jan 1, 2020 • edited Loading

Choose a reason for hiding this comment

estebank Jan 8, 2020

Choose a reason for hiding this comment

Aaron1011 Jan 8, 2020

Choose a reason for hiding this comment

This comment has been minimized.

estebank commented Jan 8, 2020 • edited Loading

Centril commented Jan 9, 2020

bors commented Jan 9, 2020

estebank commented Nov 16, 2019 •

edited

Loading

Aaron1011 Jan 1, 2020 •

edited

Loading

estebank commented Jan 8, 2020 •

edited

Loading