Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6061 : Revert commits to fix bootstrapping issue 6061 #6062

Conversation

pnkfelix
Copy link
Member

I have confirmed that reverting these two commits gets me bootstrapping again (or rather, my build finishes without erroring out during the first 1/3 of the build).

I don't know yet why these changes exposed this problem; obviously that requires investigation. But I figured it was best to try to get the build working again (and also to advertise this revert to other people who have been encountering similar problems according to the #rust channel and find out if it fixes things for them too -- so even if this pull request doesn't land, I figure I should issue it just as advertisement.)

…he generic `gen`."

This reverts commit 4a24f10
as part of Felix's attempt to resolve Issue rust-lang#6061.
This reverts commit 9860fe1
as part of Felix's attempt to resolve Issue rust-lang#6061.
@pnkfelix
Copy link
Member Author

Hmm apparently writing #6061 in the title of my pull request did not suffice to get this referenced over there? Hopefully this comment will do the job.

@catamorphism
Copy link
Contributor

This fixes the stack overflow error on my machine. I'll push a rebased version in a minute.

@catamorphism
Copy link
Contributor

I'll open a new PR.

@pnkfelix
Copy link
Member Author

(the new PR that tim referenced above is #6067)

@pnkfelix pnkfelix deleted the revert-commits-to-fix-bootstrapping-issue-6061 branch April 26, 2013 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants