Rollup of 18 pull requests #59370
Merged
Rollup of 18 pull requests #59370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When failing to parse struct-like enum variants, the ADT gets recorded as having no fields. Record that we have actually recovered during parsing of this variant to avoid complaing about non-existing fields when actually using it.
Co-Authored-By: Gabriel Smith <[email protected]>
Co-Authored-By: Gabriel Smith <[email protected]>
Co-Authored-By: Gabriel Smith <[email protected]>
Co-Authored-By: Gabriel Smith <[email protected]>
Co-Authored-By: Gabriel Smith <[email protected]>
Co-Authored-By: Gabriel Smith <[email protected]>
Co-Authored-By: llogiq <[email protected]>
…r=steveklabnik Update and clean up several parts of CONTRIBUTING.md
consistent naming for Rhs type parameter in libcore/ops Rename RHS type parameter occurrences RHS->Rhs to make it consistent throughout files and follow naming conventions.
Rename miri component to miri-preview It should fix installation via `rustup` and indicates it's not stable yet.
…etrochenkov Do not complain about non-existing fields after parse recovery When failing to parse struct-like enum variants, the ADT gets recorded as having no fields. Record that we have actually recovered during parsing of this variant to avoid complaing about non-existing fields when actually using it. Fix rust-lang#57361.
some small HIR doc improvements
…xcrichton Make Option<ThreadId> no larger than ThreadId, with NonZeroU64
…estebank convert field/method confusion help to suggestions
Move some bench tests back from libtest It doesn't make much sense to test these on rust-lang/libtest since they exercise the `#[bench]` macro which is part of rust-lang/rust. This PR moves these tests back here. r? @alexcrichton
…chton Add messages for different verbosity levels. Output copy actions.
…avidtwco Unify E0109, E0110 and E0111 Error messages should no longer be restricted to specific generic kinds.
Tweak incorrect escaped char diagnostic
…arkor use suggestions for "enum instead of variant" error
Add NAN test to docs Documents and tests NAN behavior for the new (f32, f64)::clamp function.
cleanup: Remove compile-fail-fulldeps directory again It was already removed once in rust-lang#56444, but was partially resurrected by rebase of some other PR.
Move one test from run-make-fulldeps to ui The test was written when `--extern` without path didn't exist.
Add tracking issue number for `seek_convenience` We forgot to do that in rust-lang#58422
|
@bors r+ p=18 |
|
📌 Commit cf8c739 has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Mar 22, 2019
Rollup of 18 pull requests Successful merges: - #59106 (Add peer_addr function to UdpSocket) - #59170 (Add const generics to rustdoc) - #59172 (Update and clean up several parts of CONTRIBUTING.md) - #59190 (consistent naming for Rhs type parameter in libcore/ops) - #59236 (Rename miri component to miri-preview) - #59266 (Do not complain about non-existing fields after parse recovery) - #59273 (some small HIR doc improvements) - #59291 (Make Option<ThreadId> no larger than ThreadId, with NonZeroU64) - #59297 (convert field/method confusion help to suggestions) - #59304 (Move some bench tests back from libtest) - #59309 (Add messages for different verbosity levels. Output copy actions.) - #59321 (Unify E0109, E0110 and E0111) - #59322 (Tweak incorrect escaped char diagnostic) - #59323 (use suggestions for "enum instead of variant" error) - #59327 (Add NAN test to docs) - #59329 (cleanup: Remove compile-fail-fulldeps directory again) - #59347 (Move one test from run-make-fulldeps to ui) - #59360 (Add tracking issue number for `seek_convenience`) Failed merges: r? @ghost
|
☀️ Test successful - checks-travis, status-appveyor |
This was referenced Mar 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
seek_convenience#59360 (Add tracking issue number forseek_convenience)Failed merges:
r? @ghost