Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ICE with feature self_struct_ctor #56205

Closed
wants to merge 2 commits into from
Closed

Fix ICE with feature self_struct_ctor #56205

wants to merge 2 commits into from

Conversation

estebank
Copy link
Contributor

Fix #56202.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 25, 2018
@estebank
Copy link
Contributor Author

CC @TheIronBorn

@nikomatsakis
Copy link
Contributor

@bors r+

I was going to ask @petrochenkov to review but it looks like they approve =)

@bors
Copy link
Contributor

bors commented Nov 26, 2018

📌 Commit 8d76f54 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Nov 27, 2018
@kennytm
Rollup merge of rust-lang#56205 - estebank:ice-ice-baby, r=nikomatsakis
48276a7 
Fix ICE with feature self_struct_ctor

Fix rust-lang#56202.
@kennytm kennytm mentioned this pull request Nov 27, 2018
Closed
@pietroalbini pietroalbini mentioned this pull request Nov 28, 2018
Closed
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 28, 2018
@pietroalbini
Rollup merge of rust-lang#56205 - estebank:ice-ice-baby, r=nikomatsakis
9642325 
Fix ICE with feature self_struct_ctor

Fix rust-lang#56202.
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Nov 29, 2018
@pietroalbini
Rollup merge of rust-lang#56205 - estebank:ice-ice-baby, r=nikomatsakis
593cc39 
Fix ICE with feature self_struct_ctor

Fix rust-lang#56202.
@pietroalbini pietroalbini mentioned this pull request Nov 29, 2018
Closed
@alexreg
Copy link
Contributor

alexreg commented Nov 30, 2018

This fixes #56199 too, right? You may want to add that to the PR comment, or else close it manually.

@kennytm kennytm mentioned this pull request Nov 30, 2018
Merged
@estebank
Copy link
Contributor Author

@alexreg let's add a test in a follow up PR for it.

@estebank estebank mentioned this pull request Nov 30, 2018
Closed
@Centril
Copy link
Contributor

Centril commented Nov 30, 2018

Let's see what happens with the rollup PR #56381 since it includes the changes in this PR since #56365 is rebased atop of it.

@alexreg
Copy link
Contributor

alexreg commented Nov 30, 2018 •
edited
Loading

Sure. If it goes through, we can do a very small follow-up PR.

@bors
Copy link
Contributor

bors commented Nov 30, 2018

☔ The latest upstream changes (presumably #56381) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 30, 2018
@Centril
Copy link
Contributor

Centril commented Nov 30, 2018

The commits in this PR were included in #56365 which was merged so closing therefore.

@Centril Centril closed this Nov 30, 2018
@davidtwco davidtwco mentioned this pull request Jan 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottmcm scottmcm scottmcm left review comments

@petrochenkov petrochenkov petrochenkov left review comments

@Centril Centril Centril left review comments

@alexreg alexreg alexreg left review comments

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@estebank @rust-highfive @nikomatsakis @bors @alexreg @Centril @petrochenkov @scottmcm