Update version of rls-data used with save-analysis #53442
Conversation
This part 1/3 for fixing rust-lang#53440.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cramertj (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Could you try applying a6a6230, assuming CI is not mad about it? That was the point of my change to Thanks! |
|
(Otherwise feel free to merge this first and I'll submit a followup with that change) |
|
It's probably better to do that in a followup to avoid lumping things together. (I want this version bump for a different reason than you) |
|
Fair enough, will update once that's in :) |
|
@bors: r+ rollup |
|
📌 Commit a50f29a has been approved by |
bors
added
S-waiting-on-bors
Update version of rls-data used with save-analysis This part 1/3 for fixing rust-lang#53440.
Rollup of 10 pull requests Successful merges: - #53418 (Mark some suggestions as MachineApplicable) - #53431 (Moved some feature gate ui tests to correct location) - #53442 (Update version of rls-data used with save-analysis) - #53504 (Set applicability for more suggestions.) - #53541 (Fix missing impl trait display as ret type) - #53544 (Point at the trait argument when using unboxed closure) - #53558 (Normalize source line and column numbers.) - #53562 (Lament the invincibility of the Turbofish) - #53574 (Suggest direct raw-pointer dereference) - #53585 (Remove super old comment on function that parses items) Failed merges: - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.) - #53563 (use String::new() instead of String::from(""), "".to_string(), "".to_owned() or "".into()) r? @ghost
This part 1/3 for fixing #53440.