Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed various update-reference and update-all-references scripts #51542

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Removed various update-reference and update-all-references scripts #51542

merged 1 commit into from
Jun 14, 2018
+0 −234

Conversation

ccesare
Copy link
Contributor

@ccesare ccesare commented Jun 13, 2018

A PR that addresses #50853 changes that made update-reference and update-all-references scripts obsolete.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 13, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Jun 13, 2018

@bors r+ rollup

Thanks! I totally forgot about that issue 😆

@bors
Copy link
Contributor

bors commented Jun 13, 2018

📌 Commit 2887249 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2018
@bors
Copy link
Contributor

bors commented Jun 13, 2018

⌛ Testing commit 2887249 with merge 5205ae8...

bors added a commit that referenced this pull request Jun 13, 2018
@bors
Auto merge of #51542 - ccesare:remove_update-reference, r=oli-obk
5205ae8 
Removed various update-reference and update-all-references scripts

A PR that addresses #50853 changes that made `update-reference` and `update-all-references` scripts obsolete.
@bors
Copy link
Contributor

bors commented Jun 14, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing 5205ae8 to master...

@bors bors merged commit 2887249 into rust-lang:master Jun 14, 2018
@ccesare
Copy link
Contributor Author

ccesare commented Jun 14, 2018

@oli-obk, you can close issue #50853 too.

@ccesare ccesare deleted the remove_update-reference branch August 7, 2018 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccesare @rust-highfive @oli-obk @bors @nikomatsakis