-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc: Start a custom cabi module for wasm32 #48959
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
// Copyright 2018 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
use abi::{FnType, ArgType}; | ||
use context::CodegenCx; | ||
|
||
fn classify_ret_ty<'a, 'tcx>(_cx: &CodegenCx<'a, 'tcx>, ret: &mut ArgType<'tcx>) { | ||
ret.extend_integer_width_to(32); | ||
} | ||
|
||
fn classify_arg_ty(arg: &mut ArgType) { | ||
arg.extend_integer_width_to(32); | ||
} | ||
|
||
pub fn compute_abi_info<'a, 'tcx>(cx: &CodegenCx<'a, 'tcx>, fty: &mut FnType<'tcx>) { | ||
if !fty.ret.is_ignore() { | ||
classify_ret_ty(cx, &mut fty.ret); | ||
} | ||
|
||
for arg in &mut fty.args { | ||
if arg.is_ignore() { continue; } | ||
classify_arg_ty(arg); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't do the aggregate to indirect conversion anymore that the asm.js C ABI did: https://github.com/alexcrichton/rust/blob/74f5dd07cff8dba348f91cfef4df5242ab33a311/src/librustc_trans/cabi_asmjs.rs#L20-L33
However looking at how the C ABI for wasm is implemented in clang, it seems to still do it: https://github.com/llvm-mirror/clang/blob/master/lib/CodeGen/TargetInfo.cpp#L759-L775
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah TBH I have very little clue what ABI-related code is doing...
Seems fine though for us to match clang! Until there's an "official ABI" though this'll probably be a game of cat and mouse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Seems fine though for us to match clang!"
I'm a bit confused by that wording. What I'm saying is that we don't match clang anymore with this PR, so shouldn't we include the aggregate code as well to properly match it again?
It seems to be the same as the asm.js one, so we can just copy the code from there / call it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Er sorry, what I mean is that it seems fine to add. It won't have any effect today anyway as you can't intermingle wasm32-unknown-unknown and C yet so I'm hoping that we can fix this with a test in the future. (I'm also hesitant to add things that I don't personally understand in my own PRs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it also affects everyone who is calling an exported function from JS / a wasm environment. However I guess we don't really give any guarantees how structs are represented there anyway, so I guess it's fine to wait on the C ABI settling.
Maybe we should open an issue about this though? Otherwise we might forget about this disparity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah with a lack of a spec about an ABI returning any sort of aggregate or non-integer/float is sort of "best effort" today anyway