Correct a few stability attributes #48130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ rollup |
|
📌 Commit 45d5a42 has been approved by |
bors
added
the
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Feb 12, 2018
…rect a few stability attributes CODE_OF_CONDUCT.md CONTRIBUTING.md COPYRIGHT LICENSE-APACHE LICENSE-MIT README.md RELEASES.md appveyor.yml config.toml.example configure src x.py `core_float_bits`, `duration_core`, `path_component_asref`, and `repr_align` were stabalized in 1.25.0 not 1.24.0. CODE_OF_CONDUCT.md CONTRIBUTING.md COPYRIGHT LICENSE-APACHE LICENSE-MIT README.md RELEASES.md appveyor.yml config.toml.example configure src x.py Impls for `NonNull` involving unstable things should remain unstable. CODE_OF_CONDUCT.md CONTRIBUTING.md COPYRIGHT LICENSE-APACHE LICENSE-MIT README.md RELEASES.md appveyor.yml config.toml.example configure src x.py `Duration` should remain stable since 1.3.0 so it appears correctly in the `std` docs. CODE_OF_CONDUCT.md CONTRIBUTING.md COPYRIGHT LICENSE-APACHE LICENSE-MIT README.md RELEASES.md appveyor.yml config.toml.example configure src x.py `cursor_mut_vec` is an impl on only stable things so should be marked stable.
bors
added a commit
that referenced
this pull request
Feb 12, 2018
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Feb 13, 2018
Correct a few stability attributes * `core_float_bits`, `duration_core`, `path_component_asref`, and `repr_align` were stabalized in 1.25.0 not 1.24.0. * Impls for `NonNull` involving unstable things should remain unstable. * `Duration` should remain stable since 1.3.0 so it appears correctly in the `std` docs. * `cursor_mut_vec` is an impl on only stable things so should be marked stable.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Feb 14, 2018
Correct a few stability attributes * `core_float_bits`, `duration_core`, `path_component_asref`, and `repr_align` were stabalized in 1.25.0 not 1.24.0. * Impls for `NonNull` involving unstable things should remain unstable. * `Duration` should remain stable since 1.3.0 so it appears correctly in the `std` docs. * `cursor_mut_vec` is an impl on only stable things so should be marked stable.
bors
added a commit
that referenced
this pull request
Feb 14, 2018
bors
added a commit
that referenced
this pull request
Feb 15, 2018
|
☔ The latest upstream changes (presumably #48203) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core_float_bits,duration_core,path_component_asref, andrepr_alignwere stabalized in 1.25.0 not 1.24.0.NonNullinvolving unstable things should remain unstable.Durationshould remain stable since 1.3.0 so it appears correctly in thestddocs.cursor_mut_vecis an impl on only stable things so should be marked stable.