-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move unicode Python script into libstd_unicode crate. #41763
Conversation
The only place this Python script is used is inside the libstd_unicode crate, so lets move it there.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors: r+ Nice! If you're feeling adventurous, want to open an issue for translating this to the build script as well? |
📌 Commit ed1b78c has been approved by |
Many of the scripts in |
Assuming what you mean is that we should call this Python file whenever we build this crate to generate that file (or something along those lines), one downside is that it creates another network dependency, which isn't great. Not a show stopper, but worth pointing out |
@frewsxcv oh sorry to clarify what I meant was actually rewriting the python logic in Rust, basically translating it into the build script. I had forgotten about the network dependency though! In that case let's just leave it be. |
Move unicode Python script into libstd_unicode crate. The only place this Python script is used is inside the libstd_unicode crate, so lets move it there.
⌛ Testing commit ed1b78c with merge 42a4f37... |
The only place this Python script is used is inside the libstd_unicode
crate, so lets move it there.