Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the reasoning for the Acquire/Release handshake when dropping Arcs. #41730

Merged
merged 1 commit into from
May 4, 2017
Merged

Document the reasoning for the Acquire/Release handshake when dropping Arcs. #41730

merged 1 commit into from
May 4, 2017

Conversation

bholley
Copy link
Contributor

@bholley bholley commented May 3, 2017

Split out from #41714. r? @aturon

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@aidanhs aidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2017
@aidanhs
Copy link
Member

aidanhs commented May 3, 2017

Thanks for the PR @bholley, we'll check in now and again to make sure @aturon or another reviewer gets to your PR soon.

@aturon
Copy link
Member

aturon commented May 3, 2017

Thanks @bholley!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 3, 2017

📌 Commit 7b05b88 has been approved by aturon

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 3, 2017
@frewsxcv
Rollup merge of rust-lang#41730 - bholley:arc_comment, r=aturon
e20b282 
Document the reasoning for the Acquire/Release handshake when dropping Arcs.

Split out from rust-lang#41714. r? @aturon
@frewsxcv frewsxcv mentioned this pull request May 3, 2017
Merged
bors added a commit that referenced this pull request May 3, 2017
@bors
Auto merge of #41735 - frewsxcv:rollup, r=frewsxcv
b16c7a2 
Rollup of 6 pull requests

- Successful merges: #41543, #41600, #41715, #41720, #41721, #41730
- Failed merges:
@bors bors merged commit 7b05b88 into rust-lang:master May 4, 2017
@bors
Copy link
Contributor

bors commented May 4, 2017

⌛ Testing commit 7b05b88 with merge b16c7a2...

@mzabaluev mzabaluev mentioned this pull request Jun 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bholley @rust-highfive @aidanhs @aturon @bors