-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicated styling in main.css #40725
Conversation
Some changes occurred in HTML/CSS. |
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors r+ rollup |
📌 Commit e2b5a8c has been approved by |
@bors: r-
.sidebar {
background-color: #F1F1F1;
} |
Oh.... are you sure? The file currently looks like this: .sidebar {
background-color: #F1F1F1;
}
.sidebar .current {
background-color: #fff;
}
.sidebar {
background-color: #F1F1F1;
}
.sidebar .current {
background-color: #fff;
} All I've done is remove the bottom two, which seem to be exact, letter-for-letter duplicates of the upper two. Also, if you look at an element with the If I'm tragically misunderstanding something about CSS here, I'd love to learn from this and correct my knowledge :) |
Oh damn, you're absolutely right! I stupidly looked at your file instead of the current one... My mistake. Just one thing to change though: .sidebar {
background-color: #F1F1F1;
}
.sidebar .current {
background-color: #fff;
} The .sidebar .current {
background-color: #fff;
} Could you update it this way in addition of your removal please? |
So you want the Sorry to double-guess you again, but doing that would mean that the only place the sidebar class would have to get a As you can see in the above screenshot of devtools for https://doc.rust-lang.org/nightly/std/. Toggling off both ...now gives the sidebar |
And you're absolutely right, thought it had a comma... Sorry for the loss of time. @bors: r=estebank rollup |
📌 Commit e2b5a8c has been approved by |
Remove duplicated styling in main.css If nothing else, it saves a bit of data.
Remove duplicated styling in main.css If nothing else, it saves a bit of data.
If nothing else, it saves a bit of data.