Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed some clippy warnings in libcollections #40541

Closed
wants to merge 3 commits into from
Closed

fixed some clippy warnings in libcollections #40541

wants to merge 3 commits into from

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Mar 15, 2017

Some markdown fixes, a few readability improvements, but mostly trivial stuff.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson
Copy link
Contributor

brson commented Mar 15, 2017

@bors r+ Thanks @llogiq

@bors
Copy link
Contributor

bors commented Mar 15, 2017

📌 Commit 70deac1 has been approved by brson

@arielb1 arielb1 mentioned this pull request Mar 18, 2017
Closed
bors added a commit that referenced this pull request Mar 18, 2017
@bors
Auto merge of #40644 - arielb1:rollup, r=arielb1
1d565ef 
Rollup of 22 pull requests

- Successful merges: #40241, #40346, #40348, #40377, #40398, #40409, #40441, #40445, #40509, #40521, #40523, #40532, #40538, #40564, #40581, #40583, #40588, #40589, #40590, #40603, #40611, #40621
- Failed merges: #40501, #40541
@bors
Copy link
Contributor

bors commented Mar 19, 2017

☔ The latest upstream changes (presumably #40538) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Mar 25, 2017

☔ The latest upstream changes (presumably #40806) made this pull request unmergeable. Please resolve the merge conflicts.

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Mar 29, 2017

📌 Commit 1cbfdf4 has been approved by estebank

@estebank
Copy link
Contributor

@bors r-

@estebank
Copy link
Contributor

@bors r=brson

@bors
Copy link
Contributor

bors commented Mar 29, 2017

📌 Commit 1cbfdf4 has been approved by brson

@bors
Copy link
Contributor

bors commented Mar 29, 2017

⌛ Testing commit 1cbfdf4 with merge d05de67...

@bors
Copy link
Contributor

bors commented Mar 29, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Mar 29, 2017

⌛ Testing commit 1cbfdf4 with merge 11deb59...

@bors
Copy link
Contributor

bors commented Mar 29, 2017

💔 Test failed - status-appveyor

@estebank
Copy link
Contributor

@bors retry

@frewsxcv frewsxcv mentioned this pull request Mar 30, 2017
Closed
@frewsxcv frewsxcv mentioned this pull request Mar 30, 2017
Closed
@frewsxcv frewsxcv mentioned this pull request Apr 4, 2017
Closed
@frewsxcv frewsxcv mentioned this pull request Apr 4, 2017
Closed
@bors
Copy link
Contributor

bors commented Apr 5, 2017

⌛ Testing commit 1cbfdf4 with merge 7ebc15a...

@bors
Copy link
Contributor

bors commented Apr 5, 2017

💔 Test failed - status-appveyor

@frewsxcv
Copy link
Member

frewsxcv commented Apr 5, 2017

@bors retry

1 similar comment
@frewsxcv
Copy link
Member

frewsxcv commented Apr 5, 2017

@bors retry

@bors
Copy link
Contributor

bors commented Apr 5, 2017

⌛ Testing commit 1cbfdf4 with merge 66267b3...

@bors
Copy link
Contributor

bors commented Apr 5, 2017

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

alexcrichton commented Apr 5, 2017 via email

@alexcrichton
Copy link
Member

@bors: r-

er, hang on

@alexcrichton
Copy link
Member

This PR is always failing with #40906, which makes me think it's not a spurious error. Turns out that's not happening on any other PRs as well. Even if this is just a bug in the MinGW linker, I don't think we can land this PR as-is.

@alexcrichton alexcrichton mentioned this pull request Apr 5, 2017
Closed
@bluss
Copy link
Member

bluss commented Apr 5, 2017

Scouring through, I can't find anything suspicious in the diff.

@llogiq
Copy link
Contributor Author

llogiq commented Apr 5, 2017

I think I may want to bisect this. Pity that travis doesn't show the error. Hang on...

@bluss
Copy link
Member

bluss commented Apr 5, 2017

Something hiding behind the merge in this branch?

@llogiq
Copy link
Contributor Author

llogiq commented Apr 10, 2017

I'm closing this in favor of a series of smaller PRs.

@llogiq llogiq closed this Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluss bluss bluss left review comments

@tamird tamird tamird left review comments

Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@llogiq @rust-highfive @brson @bors @estebank @alexcrichton @frewsxcv @bluss @tamird