Use .reserve() in HashMap and HashSet's extend methods #36580
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was revealed that hashmaps perform very poorly in this example code:
The explanation is that the iterators visit the keys in their bucket
order, and if both maps have the same hash function (including key),
that means that during .extend() the early buckets are overpopulated
long before the whole hashmap's fill level increases to the point that it
triggers it to grow its allocation.
Fixes #36579