Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code around LocalCrateReader. #33538

Merged
merged 5 commits into from
May 14, 2016
Merged

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented May 10, 2016

No description provided.

@rust-highfive
Copy link
Collaborator

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@Manishearth
Copy link
Member

@bors try

bors added a commit that referenced this pull request May 10, 2016
Refactor code around LocalCrateReader.
@bors
Copy link
Contributor

bors commented May 10, 2016

⌛ Trying commit 54de1fd with merge e23a651...

@arielb1
Copy link
Contributor

arielb1 commented May 10, 2016

Tidy failure:

/home/travis/build/rust-lang/rust/src/librustdoc/core.rs:161: line longer than 100 chars

@Ms2ger
Copy link
Contributor Author

Ms2ger commented May 10, 2016

Will fix.

@Ms2ger
Copy link
Contributor Author

Ms2ger commented May 10, 2016

Fixed

@arielb1
Copy link
Contributor

arielb1 commented May 10, 2016

@bors r+

@bors
Copy link
Contributor

bors commented May 10, 2016

📌 Commit a647997 has been approved by arielb1

@frewsxcv
Copy link
Member

From Travis:

src/librustdoc/test.rs:108:47: 108:51 error: mismatched types [E0308]
src/librustdoc/test.rs:108     let map = hir_map::map_crate(&mut forest, defs);
                                                                         ^~~~
src/librustdoc/test.rs:108:47: 108:51 help: run `rustc --explain E0308` to see a detailed explanation
src/librustdoc/test.rs:108:47: 108:51 note: expected type `rustc::hir::map::Definitions`
src/librustdoc/test.rs:108:47: 108:51 note:    found type `&std::cell::RefCell<rustc::hir::map::Definitions>`
error: aborting due to previous error

@arielb1
Copy link
Contributor

arielb1 commented May 11, 2016

@bors r-

@Ms2ger
Copy link
Contributor Author

Ms2ger commented May 11, 2016

Fixed

@arielb1
Copy link
Contributor

arielb1 commented May 11, 2016

@bors r+

@bors
Copy link
Contributor

bors commented May 11, 2016

📌 Commit c0e321a has been approved by arielb1

eddyb added a commit to eddyb/rust that referenced this pull request May 12, 2016
bors added a commit that referenced this pull request May 12, 2016
eddyb added a commit to eddyb/rust that referenced this pull request May 13, 2016
@bors
Copy link
Contributor

bors commented May 14, 2016

⌛ Testing commit c0e321a with merge d3ec9d4...

bors added a commit that referenced this pull request May 14, 2016
Refactor code around LocalCrateReader.
@bors bors merged commit c0e321a into rust-lang:master May 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants