Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy more libraries from local Rust to stage0 #33531

Merged
merged 1 commit into from
May 13, 2016

Conversation

antonblanchard
Copy link
Contributor

When bootstrapping Rust using a previously built toolchain, I noticed
a number of libraries were not copied in. As a result the copied in
rustc fails to execute because it can't find all its dependences.

Add them into the local_stage0.sh script.

When bootstrapping Rust using a previously built toolchain, I noticed
a number of libraries were not copied in. As a result the copied in
rustc fails to execute because it can't find all its dependences.

Add them into the local_stage0.sh script.
@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@antonblanchard
Copy link
Contributor Author

Is there a reason we don't pull in all libraries in lib/* ?

@aturon
Copy link
Member

aturon commented May 10, 2016

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton and unassigned aturon May 10, 2016
@alexcrichton
Copy link
Member

@bors: r+ 0a38089

Sure! This is basically an unmaintained script (I have no idea what it does), so I suspect "is there a reason..." is just historical or some rationale lost to time :). I suspect that copying over all libraries would also be fine I think?

Manishearth added a commit to Manishearth/rust that referenced this pull request May 12, 2016
…alexcrichton

Copy more libraries from local Rust to stage0

When bootstrapping Rust using a previously built toolchain, I noticed
a number of libraries were not copied in. As a result the copied in
rustc fails to execute because it can't find all its dependences.

Add them into the local_stage0.sh script.
eddyb added a commit to eddyb/rust that referenced this pull request May 12, 2016
…alexcrichton

Copy more libraries from local Rust to stage0

When bootstrapping Rust using a previously built toolchain, I noticed
a number of libraries were not copied in. As a result the copied in
rustc fails to execute because it can't find all its dependences.

Add them into the local_stage0.sh script.
bors added a commit that referenced this pull request May 12, 2016
eddyb added a commit to eddyb/rust that referenced this pull request May 13, 2016
…alexcrichton

Copy more libraries from local Rust to stage0

When bootstrapping Rust using a previously built toolchain, I noticed
a number of libraries were not copied in. As a result the copied in
rustc fails to execute because it can't find all its dependences.

Add them into the local_stage0.sh script.
@bors
Copy link
Contributor

bors commented May 13, 2016

⌛ Testing commit 0a38089 with merge bc57899...

bors added a commit that referenced this pull request May 13, 2016
Copy more libraries from local Rust to stage0

When bootstrapping Rust using a previously built toolchain, I noticed
a number of libraries were not copied in. As a result the copied in
rustc fails to execute because it can't find all its dependences.

Add them into the local_stage0.sh script.
@bors bors merged commit 0a38089 into rust-lang:master May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants