std: Destabilize the internals of panic! #24212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have a `#[allow_internal_unstable]` attribute for macros there's no need for these two `begin_unwind` functions to be stable. Right now the `panic!` interface is the only one we wish to stabilize, so remove the stability markers from these functions. While this is a breaking change, it is highly unlikely to break any actual code. It is recommended to use the `panic!` macro instead if it breaks explicit calls into `std::rt`. [breaking-change] cc rust-lang#24208
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -495,7 +495,6 @@ pub extern fn rust_begin_unwind(msg: fmt::Arguments, | |||
| /// on (e.g.) the inlining of other functions as possible), by moving | |||
| /// the actual formatting into this shared place. | |||
| #[inline(never)] #[cold] | |||
| #[stable(since = "1.0.0", feature = "rust1")] | |||
There was a problem hiding this comment.
Do these need explicit #[unstable] annotations?
There was a problem hiding this comment.
unstable inherits (in this case from std::rt).
|
@bors r+ |
|
📌 Commit 65e3f03 has been approved by |
|
Aren't the pretty printing tests going to fail? #23616. |
|
@rprichard you are most correct! re-r? @huonw, I just deleted |
|
@bors r+ |
|
📌 Commit 704f628 has been approved by |
alexcrichton
force-pushed
the
destabilize-begin-unwind
branch
from
704f628
to
f4270c8
Compare
This commit removes pretty-expanded from all tests that wind up calling panic! one way or another now that its internals are unstable.
alexcrichton
force-pushed
the
destabilize-begin-unwind
branch
from
f4270c8
to
ec7c800
Compare
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 9, 2015
…nd, r=huonw Now that we have a `#[allow_internal_unstable]` attribute for macros there's no need for these two `begin_unwind` functions to be stable. Right now the `panic!` interface is the only one we wish to stabilize, so remove the stability markers from these functions. While this is a breaking change, it is highly unlikely to break any actual code. It is recommended to use the `panic!` macro instead if it breaks explicit calls into `std::rt`. [breaking-change] cc rust-lang#24208
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 9, 2015
…nd, r=huonw Now that we have a `#[allow_internal_unstable]` attribute for macros there's no need for these two `begin_unwind` functions to be stable. Right now the `panic!` interface is the only one we wish to stabilize, so remove the stability markers from these functions. While this is a breaking change, it is highly unlikely to break any actual code. It is recommended to use the `panic!` macro instead if it breaks explicit calls into `std::rt`. [breaking-change] cc rust-lang#24208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have a
#[allow_internal_unstable]attribute for macros there's noneed for these two
begin_unwindfunctions to be stable. Right now thepanic!interface is the only one we wish to stabilize, so remove the stability markers
from these functions.
While this is a breaking change, it is highly unlikely to break any actual code.
It is recommended to use the
panic!macro instead if it breaks explicit callsinto
std::rt.[breaking-change]
cc #24208