Allow parsing of JSON numbers using number types other than f64 #13869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows numbers in JSON data to be parsed using any number type. With
f64
, integer values would lose precision once they exceed 2^53.This is accomplished by changing
Number(f64)
toNumber(~str)
, storing the input string instead of the parsed f64. The conversion now takes place in.as_number()
using the type parameter withFromStr
.Notable changes to tests:
test_decode_numbers
, I've changed0.4e-01
to0.5e-01
to avoid one-bit difference between compiled constant andfrom_str
output for the former number.