Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RELEASES.md: Don't document unstable --test-build-wrapper #133192

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

aDotInTheVoid
Copy link
Member

#114651 added this as an unstable flag, so it doesn't make sense to go in the release notes.

Discovered while working on #133191.

@rustbot
Copy link
Collaborator

rustbot commented Nov 18, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Nov 18, 2024
@fmease
Copy link
Member

fmease commented Nov 19, 2024

r? fmease @bors r+

@bors
Copy link
Contributor

bors commented Nov 19, 2024

📌 Commit d20a310 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2024
@fmease
Copy link
Member

fmease commented Nov 19, 2024

@bors rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 19, 2024
Rollup of 9 pull requests

Successful merges:

 - rust-lang#132758 (Improve `{BTreeMap,HashMap}::get_key_value` docs.)
 - rust-lang#133180 ([rustdoc] Fix items with generics not having their jump to def link generated)
 - rust-lang#133181 (Update books)
 - rust-lang#133182 (const_panic: inline in bootstrap builds to avoid f16/f128 crashes)
 - rust-lang#133185 (rustdoc-search: use smart binary search in bitmaps)
 - rust-lang#133186 (Document s390x-unknown-linux targets)
 - rust-lang#133187 (Add reference annotations for diagnostic attributes)
 - rust-lang#133191 (rustdoc book: Move `--test-builder(--wrapper)?` docs to unstable section.)
 - rust-lang#133192 (RELEASES.md: Don't document unstable `--test-build-wrapper`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 56747f3 into rust-lang:master Nov 19, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 19, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 19, 2024
Rollup merge of rust-lang#133192 - aDotInTheVoid:changelog-cleanup, r=fmease

RELEASES.md: Don't document unstable `--test-build-wrapper`

rust-lang#114651 added this as an unstable flag, so it doesn't make sense to go in the release notes.

Discovered while working on rust-lang#133191.
@aDotInTheVoid aDotInTheVoid deleted the changelog-cleanup branch November 19, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants