coverage: Extract safe FFI wrapper functions to llvm_cov
#132452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zalathar
added
the
A-code-coverage
|
r? @chenyukang rustbot has assigned @chenyukang. Use |
rustbot
added
S-waiting-on-review
|
Follow-up to #131962 (comment). |
Zalathar
force-pushed
the
llvm-cov-wrappers
branch
from
c3f9b13
to
5d78153
Compare
|
☔ The latest upstream changes (presumably #132581) made this pull request unmergeable. Please resolve the merge conflicts. |
Zalathar
force-pushed
the
llvm-cov-wrappers
branch
2 times, most recently
from
88451ee
to
89ce0fb
Compare
Zalathar
force-pushed
the
llvm-cov-wrappers
branch
from
89ce0fb
to
19d5dc0
Compare
|
Reverted the small change to |
|
r? jieyouxu |
jieyouxu
approved these changes
Nov 8, 2024
Comment on lines
+96
to
+97
| /// as a raw numeric value. For historical reasons, the numeric value is 1 less | ||
| /// than the number in the version's name, so `Version7` is actually `6u32`. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 8, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#132161 ([StableMIR] A few fixes to pretty printing) - rust-lang#132389 (coverage: Simplify parts of coverage graph creation) - rust-lang#132452 (coverage: Extract safe FFI wrapper functions to `llvm_cov`) - rust-lang#132590 (Simplify FFI calls for `-Ztime-llvm-passes` and `-Zprint-codegen-stats`) - rust-lang#132738 (Initialize channel `Block`s directly on the heap) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 8, 2024
Rollup merge of rust-lang#132452 - Zalathar:llvm-cov-wrappers, r=jieyouxu coverage: Extract safe FFI wrapper functions to `llvm_cov` This PR takes all of the inline `unsafe` calls in coverage codegen, and all the safe wrapper functions in `coverageinfo/mod.rs`, and moves them to a new `llvm_cov` submodule that is dedicated to safe FFI wrapper functions. This reduces the mixing of abstraction levels in the rest of coverage codegen. As a follow-up, this PR also tidies up the names and signatures of several of the coverage FFI functions.
mati865
pushed a commit
to mati865/rust
that referenced
this pull request
Nov 12, 2024
…ouxu coverage: Extract safe FFI wrapper functions to `llvm_cov` This PR takes all of the inline `unsafe` calls in coverage codegen, and all the safe wrapper functions in `coverageinfo/mod.rs`, and moves them to a new `llvm_cov` submodule that is dedicated to safe FFI wrapper functions. This reduces the mixing of abstraction levels in the rest of coverage codegen. As a follow-up, this PR also tidies up the names and signatures of several of the coverage FFI functions.
mati865
pushed a commit
to mati865/rust
that referenced
this pull request
Nov 12, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#132161 ([StableMIR] A few fixes to pretty printing) - rust-lang#132389 (coverage: Simplify parts of coverage graph creation) - rust-lang#132452 (coverage: Extract safe FFI wrapper functions to `llvm_cov`) - rust-lang#132590 (Simplify FFI calls for `-Ztime-llvm-passes` and `-Zprint-codegen-stats`) - rust-lang#132738 (Initialize channel `Block`s directly on the heap) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes all of the inline
unsafecalls in coverage codegen, and all the safe wrapper functions incoverageinfo/mod.rs, and moves them to a newllvm_covsubmodule that is dedicated to safe FFI wrapper functions. This reduces the mixing of abstraction levels in the rest of coverage codegen.As a follow-up, this PR also tidies up the names and signatures of several of the coverage FFI functions.