Vec tweaks #13241
Merged
Vec tweaks #13241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stepancheg
commented
Apr 1, 2014
stepancheg
commented
- push_all* operations should reserve capacity before pushing data to avoid unnecessary reallocations
- reserve_exact should never shrink, as specified in documentation
| @@ -230,6 +230,8 @@ impl<T: Clone> Vec<T> { | |||
| /// ``` | |||
| #[inline] | |||
| pub fn push_all(&mut self, other: &[T]) { | |||
| self.reserve_additional(other.len()); | |||
|
|
|||
There was a problem hiding this comment.
I think this method could be written as just:
fn push_all(&mut self, other: &[T]) {
self.extend(other.iter().map(|e| e.clone())
}and similarly self.extend(other.move_iter()) for push_all_move. The extend implementation includes the size reservation, and so this is more DRY etc.
reserve_exact should not shrink according to documentation.
It is shorter and also fixes missed reserve call.
|
Updated patch: push_all* now calls extend. |
bors
added a commit
that referenced
this pull request
Apr 2, 2014
* push_all* operations should reserve capacity before pushing data to avoid unnecessary reallocations * reserve_exact should never shrink, as specified in documentation
Jarcho
pushed a commit
to Jarcho/rust
that referenced
this pull request
Aug 24, 2024
…xFrednet Fix confusing message in double_must_use lint Close rust-lang#13003 As mentioned at rust-lang#13003 it isn't quite clear what it means "an empty `#[must_use]` attribute" so clarify it changelog: [none]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.