Make fuchsia-test-runner.py compatible with new JSON output from llvm-readelf #131694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed to set assignee to
|
rustbot
added
A-testsuite
|
r? @tmandry |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
c6c7
force-pushed
the
fixup-failing-fuchsia-tests
branch
from
a749f21
to
4c3e9cf
Compare
This comment has been minimized.
This comment has been minimized.
c6c7
force-pushed
the
fixup-failing-fuchsia-tests
branch
from
4c3e9cf
to
0ffa066
Compare
This comment has been minimized.
This comment has been minimized.
c6c7
force-pushed
the
fixup-failing-fuchsia-tests
branch
2 times, most recently
from
7fb0b09
to
f4c3da4
Compare
|
Verified this change fixes the error fuchsia-test-runner.py was encountering. |
This comment has been minimized.
This comment has been minimized.
c6c7
force-pushed
the
fixup-failing-fuchsia-tests
branch
2 times, most recently
from
47f8529
to
caded8d
Compare
…-readelf [A recent commit in LLVM](llvm/llvm-project@ab930ee) modified the JSON output of LLVM. The LLVM change renamed "Notes" to "NoteSections" and inserted a new "Notes" key nested under each "NoteSection". This change shores up exceptions around reading the JSON output of llvm-readelf and reads from "NoteSections" instead of the non-existent "Notes".
c6c7
force-pushed
the
fixup-failing-fuchsia-tests
branch
from
caded8d
to
5d178e1
Compare
|
r? @djkoloski |
|
Failed to set assignee to
|
|
lgtm, but I don't have commit access anymore. We can see if someone's available on zulip that could help. |
|
Started a topic in Zulip. |
|
r? infra-ci |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 16, 2024
Rollup of 10 pull requests Successful merges: - rust-lang#131582 (Add wasm32-unknown-emscripten platform support document) - rust-lang#131694 (Make fuchsia-test-runner.py compatible with new JSON output from llvm-readelf) - rust-lang#131700 (Fix match_same_arms in stable_mir) - rust-lang#131712 (Mark the unstable LazyCell::into_inner const) - rust-lang#131746 (Relax a memory order in `once_box`) - rust-lang#131754 (Don't report bivariance error when nesting a struct with field errors into another struct) - rust-lang#131760 (llvm: Match aarch64 data layout to new LLVM layout) - rust-lang#131764 (Fix unnecessary nesting in run-make test output directories) - rust-lang#131766 (Add mailmap entry for my dev-desktop setup) - rust-lang#131771 (Handle gracefully true/false in `cfg(target(..))` compact) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 16, 2024
Rollup merge of rust-lang#131694 - c6c7:fixup-failing-fuchsia-tests, r=Urgau Make fuchsia-test-runner.py compatible with new JSON output from llvm-readelf [A recent commit in LLVM](llvm/llvm-project@ab930ee) modified the JSON output of LLVM. The LLVM change renamed "Notes" to "NoteSections" and inserted a new "Notes" key nested under each "NoteSection". This change shores up exceptions around reading the JSON output of llvm-readelf and reads from "NoteSections" instead of the non-existent "Notes". r? `@erickt`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit in LLVM modified the JSON output of LLVM. The LLVM change renamed "Notes" to "NoteSections" and inserted a new "Notes" key nested under each "NoteSection".
This change shores up exceptions around reading the JSON output of llvm-readelf and reads from "NoteSections" instead of the non-existent "Notes".
r? @erickt