-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elaboration tweaks #127388
Elaboration tweaks #127388
Conversation
This comment has been minimized.
This comment has been minimized.
b3049b4
to
99429a6
Compare
@bors r+ rollup |
☀️ Test successful - checks-actions |
Finished benchmarking commit (8a8ad34): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (secondary 0.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 2.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResults (secondary -0.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 696.747s -> 701.007s (0.61%) |
Removes
Filter::OnlySelfThatDefines
and reimplementstransitive_bounds_that_define_assoc_item
as a separate function, since I don't want to have to uplift that mode since it's both an implementation detail (only exists to avoid cycles in astconv) and requires exposingIdent
as an associated type onInterner
.r? lcnr