Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use functions from crt_externs.h on iOS/tvOS/watchOS/visionOS #125225

Merged
merged 4 commits into from
May 21, 2024

Commits on May 17, 2024

  1. Configuration menu
    Copy the full SHA
    6016bad View commit details
    Browse the repository at this point in the history
  2. Use _NSGetArgc/_NSGetArgv on iOS/tvOS/watchOS/visionOS

    If we're comfortable using `_NSGetEnviron` from `crt_externs.h`, there shouldn't be an issue with using these either, and then we can merge with the macOS implementation.
    
    This also fixes two test cases on Mac Catalyst:
    - `tests/ui/command/command-argv0.rs`, maybe because `[[NSProcessInfo processInfo] arguments]` somehow converts the name of the first argument?
    - `tests/ui/env-funky-keys.rs` since we no longer link to Foundation.
    madsmtm committed May 17, 2024
    Configuration menu
    Copy the full SHA
    8f18e4f View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. Configuration menu
    Copy the full SHA
    abd5d0e View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Configuration menu
    Copy the full SHA
    38ad851 View commit details
    Browse the repository at this point in the history