-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test ABI compatibility for some unsized types as well #115678
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
5e8506e
to
c77a5be
Compare
This comment was marked as resolved.
This comment was marked as resolved.
3f1a20f
to
6f2c051
Compare
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (deb708a): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 630.656s -> 631.075s (0.07%) |
and test for what
DispatchFromDyn
needs.Also I ran this on a whole bunch of targets via Miri and added enough
cfg
to make it all work, as documentation for what does and doesn't currently work. (Most of those targets do not have their tests run on CI anyway.)Here's the shell rune I used for that: