Rework `no_coverage` to `coverage(off)` #114656

bossmc · 2023-08-09T14:59:57Z

As discussed at the tail of #84605 this replaces the no_coverage attribute with a coverage attribute that takes sub-parameters (currently off and on) to control the coverage instrumentation.

Allows future-proofing for things like coverage(off, reason="Tested live", issue="#12345") or similar.

rustbot · 2023-08-09T15:00:07Z

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-08-09T15:00:11Z

Changes to the code generated for builtin derived traits.

cc @nnethercote

mati865 · 2023-08-09T15:41:11Z

Fantastic!
I've been getting to do it myself but couldn't find the time. While I was thinking about it I think I thought some grace period would be nice given how widespread this feature is (if it's not too hard to do). Otherwise it might be hard to coordinate with crates like https://github.com/taiki-e/coverage-helper

bossmc · 2023-08-09T18:32:23Z

The old model uses a feature-flag called no_coverage to control access to an attribute called no_coverage (which, as you say, might be baked into various tools). The new model uses the coverage feature flag to control access to the coverage attribute. I suppose we could just leave the old feature and attribute as they were (with a lint warning that they're being dropped in favour of the new one?) to act as a grace period.

rustbot · 2023-08-09T18:45:09Z

Some changes occurred in src/tools/rust-analyzer

cc @rust-lang/rust-analyzer

compiler/rustc_feature/src/active.rs

compiler/rustc_codegen_ssa/src/codegen_attrs.rs

compiler/rustc_feature/src/active.rs

library/core/src/cmp.rs

oli-obk · 2023-09-05T07:59:19Z

@bors r+

bors · 2023-09-05T07:59:22Z

📌 Commit 60a9007 has been approved by oli-obk

It is now in the queue for this repository.

bors · 2023-09-05T09:10:34Z

⌛ Testing commit 60a9007 with merge e216e03ca4c1bae9b161ea9b659cdec63171596e...

bors · 2023-09-05T09:33:45Z

💔 Test failed - checks-actions

Zalathar · 2023-09-05T09:39:25Z

A few of the tests in tests/run-coverage use #[no_coverage], so they’ll need to be updated and re-blessed.

Note that those tests only run if you have the profiler runtime enabled in your config.toml (otherwise they automatically get ignored silently).

rust-timer · 2023-09-14T05:59:24Z

Finished benchmarking commit (c728bf3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.7%	[0.7%, 0.8%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.8%	[-13.3%, -2.1%]	4
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	2
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.0%]	2

Bootstrap: 631.556s -> 631.545s (-0.00%)
Artifact size: 317.95 MiB -> 317.98 MiB (0.01%)

Fix the error message for `#![feature(no_coverage)]` When rust-lang#114656 was written, the feature flag to replace `no_coverage` was originally spelled `coverage`, but it was eventually changed to `coverage_attribute` instead. That update happened to miss this error message in `removed.rs`, and unfortunately I only noticed just *after* the original PR was approved and merged. cc `@bossmc` (original author) `@oli-obk` (original reviewer) `@rustbot` label +A-code-coverage

Fix the error message for `#![feature(no_coverage)]` When rust-lang#114656 was written, the feature flag to replace `no_coverage` was originally spelled `coverage`, but it was eventually changed to `coverage_attribute` instead. That update happened to miss this error message in `removed.rs`, and unfortunately I only noticed just *after* the original PR was approved and merged. cc ``@bossmc`` (original author) ``@oli-obk`` (original reviewer) ``@rustbot`` label +A-code-coverage

Rollup merge of rust-lang#115832 - Zalathar:fix-no-coverage, r=oli-obk Fix the error message for `#![feature(no_coverage)]` When rust-lang#114656 was written, the feature flag to replace `no_coverage` was originally spelled `coverage`, but it was eventually changed to `coverage_attribute` instead. That update happened to miss this error message in `removed.rs`, and unfortunately I only noticed just *after* the original PR was approved and merged. cc ``@bossmc`` (original author) ``@oli-obk`` (original reviewer) ``@rustbot`` label +A-code-coverage

See: - rust-lang/rust#84605 - rust-lang/rust#114656

The way coverage is enabled/disabled was changed upstream. Links: rust-lang/rust#114656

nightly has updated the coverage feature to coverage_attribute. See rust-lang/rust#114656

…/rust#114656

* `rust-ini` 0.20 bumped `ordered-multimap` to 0.7 * `ordered-multimap 0.71` fixed a feature renaming sgodwincs/ordered-multimap-rs@131ab56 * The feature renaming is required for downstream application to bump nightly rust-toolchain. see rust-lang/rust#114656 Please release a minor or patch version (both are OK because the update only breaks nightly toolchain and affect nothing on stable toolchain) after the PR got merged. Signed-off-by: TennyZhuang <[email protected]>

rustbot assigned oli-obk Aug 9, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 9, 2023

This comment has been minimized.

Sign in to view

bossmc force-pushed the rework-no-coverage-attr branch from 1c02438 to 9a5ac56 Compare August 9, 2023 18:45

oli-obk reviewed Aug 11, 2023

View reviewed changes

compiler/rustc_feature/src/active.rs Show resolved Hide resolved

estebank self-assigned this Aug 11, 2023

bossmc force-pushed the rework-no-coverage-attr branch from c7e6502 to 8239f59 Compare August 11, 2023 22:29

clarfonthey reviewed Aug 24, 2023

View reviewed changes

compiler/rustc_codegen_ssa/src/codegen_attrs.rs Outdated Show resolved Hide resolved

clarfonthey reviewed Aug 24, 2023

View reviewed changes

compiler/rustc_feature/src/active.rs Outdated Show resolved Hide resolved

clarfonthey reviewed Aug 24, 2023

View reviewed changes

library/core/src/cmp.rs Show resolved Hide resolved

oli-obk unassigned estebank Sep 5, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2023

Zalathar mentioned this pull request Sep 5, 2023

coverage: Move unused-function synthesis into its own submodule #115505

Closed

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 5, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 14, 2023

bors merged commit c728bf3 into rust-lang:master Sep 14, 2023
11 checks passed

rustbot added this to the 1.74.0 milestone Sep 14, 2023

This was referenced Sep 14, 2023

(DRAFT) Combined draft branch for coverage work #115428

Closed

Disable CFI for core and std CFI violations #115200

Merged

Zalathar mentioned this pull request Sep 14, 2023

Fix the error message for #![feature(no_coverage)] #115832

Merged

bors mentioned this pull request Sep 14, 2023

Accept additional user-defined syntax classes in fenced code blocks #110800

Merged

zitsen added a commit to taosdata/taos-connector-rust that referenced this pull request Sep 15, 2023

fix: remove no_coverage feature

efe5723

See: - rust-lang/rust#84605 - rust-lang/rust#114656

QuantumDancer mentioned this pull request Sep 15, 2023

error[E0557]: feature has been removed time-rs/time#618

Closed

bossmc mentioned this pull request Sep 15, 2023

Tracking issue for function attribute #[coverage] #84605

Open

kchibisov added a commit to kchibisov/calloop that referenced this pull request Sep 16, 2023

Fix coverage testing on the CI

8e3b443

The way coverage is enabled/disabled was changed upstream. Links: rust-lang/rust#114656

kchibisov mentioned this pull request Sep 16, 2023

Fix coverage testing on the CI Smithay/calloop#150

Merged

kchibisov added a commit to kchibisov/calloop that referenced this pull request Sep 16, 2023

Fix coverage testing on the CI

31c179e

The way coverage is enabled/disabled was changed upstream. Links: rust-lang/rust#114656

kchibisov added a commit to kchibisov/calloop that referenced this pull request Sep 16, 2023

Fix coverage testing on the CI

a3501cf

The way coverage is enabled/disabled was changed upstream. Links: rust-lang/rust#114656

elinorbgr pushed a commit to Smithay/calloop that referenced this pull request Sep 18, 2023

Fix coverage testing on the CI

2feb1cf

The way coverage is enabled/disabled was changed upstream. Links: rust-lang/rust#114656

davidhewitt mentioned this pull request Sep 18, 2023

update to coverage_attribute feature pydantic/pydantic-core#966

Merged

4 tasks

colifran mentioned this pull request Sep 18, 2023

chore: replace no_coverage attribute with new coverage attribute cdklabs/cdk-from-cfn#268

Merged

vthib added a commit to vthib/boreal that referenced this pull request Sep 26, 2023

ci: fix coverage computation

d77341e

nightly has updated the coverage feature to coverage_attribute. See rust-lang/rust#114656

vthib added a commit to vthib/boreal that referenced this pull request Sep 27, 2023

ci: fix coverage computation

414a750

nightly has updated the coverage feature to coverage_attribute. See rust-lang/rust#114656

LetsMelon added a commit to LetsMelon/rusvid that referenced this pull request Oct 13, 2023

comment out all 'no_coverage', see rust-lang/rust#84605 and rust-lang…

768ced3

…/rust#114656

TennyZhuang mentioned this pull request Oct 27, 2023

chore(deps): Bump rust-ini to 0.20 Xuanwo/reqsign#374

Merged

mxfactorial mentioned this pull request Oct 29, 2023

Support for #[no_coverage] xd009642/tarpaulin#860

Closed

bossmc deleted the rework-no-coverage-attr branch January 9, 2024 03:16

This was referenced Jul 29, 2024

Support the new coverage(off) attribute format xd009642/tarpaulin#1591

Closed

Support #[coverage(off)] to exclude results xd009642/tarpaulin#1592

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rework `no_coverage` to `coverage(off)` #114656

Rework `no_coverage` to `coverage(off)` #114656

bossmc commented Aug 9, 2023

rustbot commented Aug 9, 2023

rustbot commented Aug 9, 2023

This comment has been minimized.

mati865 commented Aug 9, 2023

bossmc commented Aug 9, 2023

rustbot commented Aug 9, 2023

oli-obk commented Sep 5, 2023

bors commented Sep 5, 2023

bors commented Sep 5, 2023

This comment has been minimized.

bors commented Sep 5, 2023

Zalathar commented Sep 5, 2023

rust-timer commented Sep 14, 2023

Rework no_coverage to coverage(off) #114656

Rework no_coverage to coverage(off) #114656

Conversation

bossmc commented Aug 9, 2023

rustbot commented Aug 9, 2023

rustbot commented Aug 9, 2023

This comment has been minimized.

mati865 commented Aug 9, 2023

bossmc commented Aug 9, 2023

rustbot commented Aug 9, 2023

oli-obk commented Sep 5, 2023

bors commented Sep 5, 2023

bors commented Sep 5, 2023

This comment has been minimized.

bors commented Sep 5, 2023

Zalathar commented Sep 5, 2023

rust-timer commented Sep 14, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Rework `no_coverage` to `coverage(off)` #114656

Rework `no_coverage` to `coverage(off)` #114656