Reuse LLVMConstInBoundsGEP2

[workingjubilee]

We have had LLVM 14 as our minimum for a bit now.

[rustbot]

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

[rustbot]

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

[workingjubilee]

This binds against an already-present definition, I don't believe bumping the LLVM CI stamp is appropriate, if I understand things correctly?

[klensy]

At time when i placed this comment i didn't realized that current minimum llvm was 14. Is there easy to find places where it noted?

[cuviper]

The easiest thing to see is the PR job that runs on the minimum, currently x86_64-gnu-llvm-14.

We also mention updates in RELEASES.md, and the actual enforcement is here:

rust/src/bootstrap/llvm.rs

Lines 519 to 533 in fd68a6d

	fn check_llvm_version(builder: &Builder<'_>, llvm_config: &Path) {
	if builder.config.dry_run() {
	return;
	}
	let mut cmd = Command::new(llvm_config);
	let version = output(cmd.arg("--version"));
	let mut parts = version.split('.').take(2).filter_map(|s| s.parse::<u32>().ok());
	if let (Some(major), Some(_minor)) = (parts.next(), parts.next()) {
	if major >= 14 {
	return;
	}
	}
	panic!("\n\nbad LLVM version: {}, need >=14.0\n\n", version)
	}

[cuviper]

@bors r+

This binds against an already-present definition, I don't believe bumping the LLVM CI stamp is appropriate, if I understand things correctly?

Yeah, the bot is too aggressive, set for anything in compiler/rustc_llvm/llvm-wrapper which is really after the fact.

[bors]

📌 Commit 0726c78 has been approved by cuviper

It is now in the queue for this repository.