Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make ice msg "Unknown runtime phase" a bit nicer #112738

Merged
merged 1 commit into from
Jun 17, 2023
Merged

make ice msg "Unknown runtime phase" a bit nicer #112738

merged 1 commit into from
Jun 17, 2023

Conversation

matthiaskrgr
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jun 17, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 17, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Jun 17, 2023

While you're at it, you can change those panic! invocations to bug! invocations

@oli-obk
Copy link
Contributor

oli-obk commented Jun 17, 2023

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned cjgillot Jun 17, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Jun 17, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 17, 2023

📌 Commit 32aee06 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 17, 2023
@matthiaskrgr
Rollup merge of rust-lang#112738 - matthiaskrgr:ice_msg, r=oli-obk
715c61e 
make ice msg "Unknown runtime phase" a bit nicer
This was referenced Jun 17, 2023
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 17, 2023
@bors
Auto merge of rust-lang#112746 - matthiaskrgr:rollup-se59bfd, r=matth…
3b2073f 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#110805 (Github action to periodically `cargo update` to keep dependencies current)
 - rust-lang#112435 (Allow overwriting the sysroot compile flag via --rustc-args)
 - rust-lang#112610 (Bump stdarch)
 - rust-lang#112619 (Suggest bumping download-ci-llvm-stamp if the build config for llvm changes)
 - rust-lang#112738 (make ice msg "Unknown runtime phase" a bit nicer)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5518eb8 into rust-lang:master Jun 17, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
5 participants
@matthiaskrgr @rustbot @oli-obk @bors @cjgillot