Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only rewrite valtree-constants to patterns and keep other constants opaque #111913

Merged
merged 12 commits into from
May 31, 2023
Merged

Only rewrite valtree-constants to patterns and keep other constants opaque #111913

merged 12 commits into from
May 31, 2023

Commits on May 30, 2023

  1. Lower the tracing level of some very verbose messages

    @oli-obk
    oli-obk committed May 30, 2023
    Configuration menu
    Copy the full SHA
    f8b5e00 View commit details
    Browse the repository at this point in the history

  2. Get lit_to_const in sync with const_to_valtree_inner 

    Without this, we'd have a discrepancy where float literals are not lowered to valtrees, but float constants are.
    @oli-obk
    oli-obk committed May 30, 2023
    Configuration menu
    Copy the full SHA
    e40b51d View commit details
    Browse the repository at this point in the history

  3. Remove a hack that has become obsolete after rust-lang#108080

    @oli-obk
    oli-obk committed May 30, 2023
    Configuration menu
    Copy the full SHA
    7a2f47c View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. Only rewrite valtree-constants to patterns and keep other constants o… 

    …paque
    @oli-obk
    oli-obk committed May 31, 2023
    Configuration menu
    Copy the full SHA
    d030ece View commit details
    Browse the repository at this point in the history

  2. Remove deref_mir_constant

    @oli-obk
    oli-obk committed May 31, 2023
    Configuration menu
    Copy the full SHA
    aa3a186 View commit details
    Browse the repository at this point in the history

  3. Remove lit_to_mir_constant query

    @oli-obk
    oli-obk committed May 31, 2023
    Configuration menu
    Copy the full SHA
    4ca8707 View commit details
    Browse the repository at this point in the history

  4. Remove some dead code

    @oli-obk
    oli-obk committed May 31, 2023
    Configuration menu
    Copy the full SHA
    1722aa7 View commit details
    Browse the repository at this point in the history

  5. Simplify an if let Some to a ?

    @oli-obk
    oli-obk committed May 31, 2023
    Configuration menu
    Copy the full SHA
    bd4197c View commit details
    Browse the repository at this point in the history

  6. bug! message nit

    @oli-obk
    oli-obk committed May 31, 2023
    Configuration menu
    Copy the full SHA
    9cf7810 View commit details
    Browse the repository at this point in the history

  7. Explain and simplify valtree -> mir-const fallback

    @oli-obk
    oli-obk committed May 31, 2023
    Configuration menu
    Copy the full SHA
    c4d5dde View commit details
    Browse the repository at this point in the history

  8. Inline from_inline_const into its sole call site

    @oli-obk
    oli-obk committed May 31, 2023
    Configuration menu
    Copy the full SHA
    81b07ed View commit details
    Browse the repository at this point in the history

  9. Explain the reason for why a test exists

    @oli-obk
    oli-obk committed May 31, 2023
    Configuration menu
    Copy the full SHA
    3c02cfc View commit details
    Browse the repository at this point in the history