-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix documenting for non-x86 targets #111394
Conversation
r? @thomcc (rustbot has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
This comment has been minimized.
This comment has been minimized.
@rustbot author |
These errors occur when cross compiling the LoongArch target on x86: ``` Documenting std v0.0.0 (/home/hev/git/rust/rust/library/std) error[E0412]: cannot find type `WSADATA` in this scope --> library/std/src/sys/windows/c/windows_sys.rs:715:63 | 715 | pub fn WSAStartup(wversionrequested: u16, lpwsadata: *mut WSADATA) -> i32; | ^^^^^^^ not found in this scope error[E0412]: cannot find type `CONTEXT` in this scope --> library/std/src/sys/windows/c/windows_sys.rs:3034:29 | 3034 | pub ContextRecord: *mut CONTEXT, | ^^^^^^^ not found in this scope For more information about this error, try `rustc --explain E0412`. error: could not document `std` ``` Fixes: e92ee03 ("Generate windows-sys bindings")
@rustbot ready |
The code in this file is auto-generated so any changes will be overwritten. Instead it'd be better to modify c.rs to add the two missing types for this target ( |
So I think it'd be better to add some dummy types to generate-windows-sys so that it will compile on other targets. @rustbot author |
…rkingjubilee Don't force include Windows goop when documenting Why do we need to include all the windows bits on non-windows platforms? Let's try not doing that. Possible alternative to rust-lang#111394, if it works.
These errors occur when cross compiling the LoongArch target on x86:
Fixes: e92ee03 ("Generate windows-sys bindings")