Refine error spans for const args in hir typeck #108961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
force-pushed
the
refine-ct-errors
branch
from
a103b5e to
a482363
Compare
|
r? compiler |
|
r? @BoxyUwU |
compiler-errors
force-pushed
the
refine-ct-errors
branch
from
a482363 to
66a5a6f
Compare
BoxyUwU
reviewed
Mar 20, 2023
compiler/rustc_hir_typeck/src/fn_ctxt/adjust_fulfillment_errors.rs
Outdated
Show resolved
Hide resolved
compiler/rustc_hir_typeck/src/fn_ctxt/adjust_fulfillment_errors.rs
Outdated
Show resolved
Hide resolved
| @@ -8,7 +8,7 @@ error: the constant `ASSUME_ALIGNMENT` is not of type `Assume` | |||
| --> $DIR/issue-101739-1.rs:8:14 | |||
| | | |||
| LL | Dst: BikeshedIntrinsicFrom<Src, Context, ASSUME_ALIGNMENT>, | |||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | |||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `Assume`, found `bool` | |||
There was a problem hiding this comment.
do we have the "machinery" in rustc to do the same thing as with exprs, for other paths so that this has a nicer span?
There was a problem hiding this comment.
No, this has to do with wfcheck which notoriously has bad spans, e.g. playground. I've looked into it, doesn't seem to have a good solution.
compiler-errors
force-pushed
the
refine-ct-errors
branch
from
66a5a6f to
2e7472f
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup since this is on the error path only |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 23, 2023
…r=BoxyUwU Refine error spans for const args in hir typeck Improve just a couple of error messages having to do with mismatched consts. r? `@ghost` i'll put this up when the dependent commits are merged
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 23, 2023
…r=BoxyUwU Refine error spans for const args in hir typeck Improve just a couple of error messages having to do with mismatched consts. r? ``@ghost`` i'll put this up when the dependent commits are merged
|
@bors r- |
bors
added
S-waiting-on-author
compiler-errors
force-pushed
the
refine-ct-errors
branch
from
2e7472f to
6c6bd01
Compare
|
blessed @bors r=BoxyUwU |
bors
removed
the
S-waiting-on-author
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 24, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#108629 (rustdoc: add support for type filters in arguments and generics) - rust-lang#108924 (panic_immediate_abort requires abort as a panic strategy) - rust-lang#108961 (Refine error spans for const args in hir typeck) - rust-lang#108986 (sync LVI tests) - rust-lang#109142 (Add block-based mutex unlocking example) - rust-lang#109368 (fix typo in the creation of OpenOption for RustyHermit) - rust-lang#109493 (Return nested obligations from canonical response var unification) - rust-lang#109515 (Add AixLinker to support linking on AIX) - rust-lang#109536 (resolve: Rename some cstore methods to match queries and add comments) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve just a couple of error messages having to do with mismatched consts.
r? @ghost i'll put this up when the dependent commits are merged