Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ICU4X to 1.1.0 #107673

Merged
merged 1 commit into from
Feb 15, 2023
Merged

update ICU4X to 1.1.0 #107673

merged 1 commit into from
Feb 15, 2023

Conversation

lukas-code
Copy link
Member

This patch updates the ICU4X crates to version 1.1.0 and regenerates the static data for rustc_baked_icu_data.

This is mostly an internal and bugfix update. It notably includes unicode-org/icu4x#2834 to fix the future compatibility warning for BYTE_SLICE_IN_PACKED_STRUCT_WITH_DERIVE.

full changelog

@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2023

r? @michaelwoerister

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 4, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 4, 2023

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

These commits modify the Cargo.lock file. Random changes to Cargo.lock can be introduced when switching branches and rebasing PRs.
This was probably unintentional and should be reverted before this PR is merged.

If this was intentional then you can ignore this comment.

@michaelwoerister
Copy link
Member

Thanks for the PR, @lukas-code! Let's find a reviewer who knows about this part of the code.

r? @davidtwco

@rustbot rustbot assigned davidtwco and unassigned michaelwoerister Feb 6, 2023
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 13, 2023

📌 Commit 0d6fdef has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 14, 2023
@matthiaskrgr
Rollup merge of rust-lang#107673 - lukas-code:update-icu4x, r=davidtwco
0c5c12e 
update ICU4X to 1.1.0

This patch updates the ICU4X crates to version 1.1.0 and regenerates the static data for `rustc_baked_icu_data`.

This is mostly an internal and bugfix update. It notably includes unicode-org/icu4x#2834 to fix the future compatibility warning for [`BYTE_SLICE_IN_PACKED_STRUCT_WITH_DERIVE`](rust-lang#107457).

[full changelog](https://github.com/unicode-org/icu4x/blob/icu%401.1.0/CHANGELOG.md)
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 14, 2023
Closed
@klensy klensy mentioned this pull request Feb 14, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 14, 2023
Merged
@Manishearth
Copy link
Member

Manishearth commented Feb 14, 2023 •
edited
Loading

Ddi you manually patch the pub into struct BakedDataProvider? The way to do this moving forward is what I've done in #108054, fwiw.

This is fine too, though. I can fix it later.

@lukas-code
Copy link
Member Author

I just ran the command from the docs and didn't change the generated files.

cd compiler/rustc_baked_icu_data
rm -r src/data
icu4x-datagen -W --pretty --fingerprint --use-separate-crates --format mod -l en es fr it ja pt ru tr zh zh-Hans zh-Hant -k list/and@1 fallback/likelysubtags@1 fallback/parents@1 fallback/supplement/co@1 --cldr-tag latest --icuexport-tag latest -o src/data

icu4x-datagen -Vv is entirely unhelpful, but cargo install --list says I have v1.1.1 installed.

@Manishearth
Copy link
Member

Ah, that's v1.1.1, I see. I was running v1.1.0

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 14, 2023
@bors
Auto merge of rust-lang#108056 - matthiaskrgr:rollup-oa6bxvh, r=matth…
0416b1a 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#107573 (Update the minimum external LLVM to 14)
 - rust-lang#107626 (Fix `x fix` on the standard library itself)
 - rust-lang#107673 (update ICU4X to 1.1.0)
 - rust-lang#107733 (Store metrics from `metrics.json` to CI PGO timer)
 - rust-lang#108007 (Use `is_str` instead of string kind comparison)
 - rust-lang#108033 (add an unstable `#[rustc_coinductive]` attribute)
 - rust-lang#108039 (Refactor refcounted structural_impls via functors)
 - rust-lang#108040 (Use derive attributes for uninteresting traversals)
 - rust-lang#108044 (interpret: rename Pointer::from_addr → from_addr_invalid)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3549e42 into rust-lang:master Feb 15, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 15, 2023
@lukas-code lukas-code deleted the update-icu4x branch February 15, 2023 12:50
@robertbastian robertbastian mentioned this pull request Feb 17, 2023
Merged
Jarcho pushed a commit to Jarcho/rust that referenced this pull request Feb 26, 2023
@bors
Auto merge of rust-lang#108056 - matthiaskrgr:rollup-oa6bxvh, r=matth…
5a8b288 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#107573 (Update the minimum external LLVM to 14)
 - rust-lang#107626 (Fix `x fix` on the standard library itself)
 - rust-lang#107673 (update ICU4X to 1.1.0)
 - rust-lang#107733 (Store metrics from `metrics.json` to CI PGO timer)
 - rust-lang#108007 (Use `is_str` instead of string kind comparison)
 - rust-lang#108033 (add an unstable `#[rustc_coinductive]` attribute)
 - rust-lang#108039 (Refactor refcounted structural_impls via functors)
 - rust-lang#108040 (Use derive attributes for uninteresting traversals)
 - rust-lang#108044 (interpret: rename Pointer::from_addr → from_addr_invalid)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lukas-code @rustbot @michaelwoerister @davidtwco @bors @Manishearth