Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: mobile sidebar has gap at top and bottom #99691

Closed
jsha opened this issue Jul 24, 2022 · 1 comment · Fixed by #99713
Closed

rustdoc: mobile sidebar has gap at top and bottom #99691

jsha opened this issue Jul 24, 2022 · 1 comment · Fixed by #99713
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jsha
Copy link
Contributor

jsha commented Jul 24, 2022

Steps to reproduce:

  1. In mobile Chrome, visit https://doc.rust-lang.org/nightly/std/index.html.
  2. Click the hamburger menu in upper left.

Expected results:

Sidebar opens and presents a solid background with no gaps.

Actual result:

Sidebar opens and there is a gap at top and bottom showing the main page.

image

This is a regression from beta to nightly. Possibly related to @GuillaumeGomez's recent refactoring of how colors are applied for themes.

@jsha jsha added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Jul 24, 2022
@GuillaumeGomez
Copy link
Member

I's pretty bad indeed. I'll take a look at it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants